Replace getPersonalDetailByEmail with usePersonalDetailByLogin for expensify and company cards - #99427
Open
bernhardoj wants to merge 5 commits into
Conversation
…sue new expensify cards page
…mpany card custom name
melvin-bot
Bot
requested review from
flaviadefaria and
shubham1206agra
and removed request for
a team
August 25, 2026 13:24
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7da16af4dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
@bernhardoj Fix ESLint please |
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-08-26.at.3.26.16.PM.mov |
shubham1206agra
approved these changes
Aug 26, 2026
| const employeePersonalDetails = usePersonalDetailsByLogins(Object.keys(policy?.employeeList ?? {})); | ||
| const currentAssigneeFirstName = usePersonalDetailByLogin(issueNewCard?.data?.assigneeEmail, (personalDetail) => { | ||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
| return Str.removeSMSDomain(personalDetail?.firstName || issueNewCard?.data?.assigneeEmail || ''); |
Contributor
There was a problem hiding this comment.
@bernhardoj Please use formatPhoneNumber instead of Str.removeSMSDomain here.
| const data = issueNewCard?.data; | ||
| const userName = usePersonalDetailByLogin(data?.assigneeEmail, (personalDetail) => { | ||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
| return Str.removeSMSDomain(personalDetail?.firstName || data?.assigneeEmail || ''); |
Contributor
There was a problem hiding this comment.
@bernhardoj Please use formatPhoneNumber instead of Str.removeSMSDomain here.
| const data = issueNewCard?.data; | ||
| const cardholder = usePersonalDetailByLogin(data?.assigneeEmail, (personalDetail) => { | ||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
| return Str.removeSMSDomain(personalDetail?.displayName || data?.assigneeEmail || ''); |
Contributor
There was a problem hiding this comment.
@bernhardoj Please use formatPhoneNumber instead of Str.removeSMSDomain here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #66391
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite: have a workspace with an Expensify card
{display name or email}'s cardCompany card
Prerequisite: have a workspace with 1 member only and an unassigned company card
{first name or email}'s cardPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4
web.cc.mp4