fix: localization dates not being localized correctly by TaduJR · Pull Request #91569 · Expensify/App

TaduJR · 2026-05-25T06:40:03Z

Explanation of Change

Display dates ignored the user's language. A Spanish user saw ago 19, 2025 a 12:02 PM: the month name was translated, but the order, the separators and the 12-hour clock were still English. Spanish writes 19 ago 2025. Translating the words isn't enough field order and clock style are part of the language too, and only Intl.DateTimeFormat knows them per locale.

Every date a user reads now goes through Intl.DateTimeFormat using a named format from CONST.DATE.INTL_FORMATS, with the locale passed in as an argument rather than read from a global.

Dates sent to the API or written to Onyx are untouched and still use yyyy-MM-dd HH:mm:ss. Those formats now have their own type, so a locale can no longer be passed where a format string belongs that mix-up is what crashed the second attempt.

The calendar starts the week on the correct day per locale via Intl.Locale.getWeekInfo(), with a fallback for Firefox and older Hermes builds that don't expose it.

Two things I'd like your call on:

English stays on Monday. CLDR maps en to en-US, which starts on Sunday. Following that would shift the calendar for every existing English user, so I kept Monday. Easy to change if you'd prefer the CLDR behaviour.
This adds @formatjs/intl-relativetimeformat (native only). Hermes doesn't implement Intl.RelativeTimeFormat, so "Last synced 2 hours ago" renders blank on iOS and Android without it. It's the fifth polyfill of this kind already in the repo and it no-ops on web, where the API exists.

Fixed Issues

$ #69562
PROPOSAL: #69562 (comment)

Tests

Setup: You will switch languages several times. The language setting is at Settings > Preferences > Language. Switch back to English between sections unless a step says otherwise.

Throughout, a date is only correct if the whole thing matches the reference table below, not just the month name. The bug being fixed is that dates used Spanish/German words in English order.

Reference — a date/time of 19 August 2025, 2:30 PM should read:

Language	Full date	Date, no year	Time
English	Aug 19, 2025	Aug 19	2:30 PM
Spanish	19 ago 2025	19 ago	14:30
German	19.08.2025	19. Aug.	14:30
French	19 août 2025	19 août	14:30
Japanese	2025/08/19	8月19日	14:30
Portuguese (BR)	19 de ago. de 2025	19 de ago.	14:30

Two things that are correct and should not be reported as bugs:

Spanish, French and Portuguese month names are lowercase (19 ago, not 19 Ago). Those languages do not capitalise months.
German full dates are all numbers (19.08.2025). That is how German writes a medium date.

1. Chat message timestamps

Open any chat with older messages.
In English, check the timestamp next to a sender's name. Today's messages read Today at 2:30 PM, older ones Aug 19, 2025 at 2:30 PM.
Switch to Spanish. The same timestamps now read Hoy a las 14:30 and 19 ago 2025 a 14:30.
Switch to German: Heute um 14:30 and 19.08.2025 um 14:30.
Verify no timestamp is blank, and none shows a stray word on its own (e.g. Today at with no time after it).

2. Expense list dates

Go to the Reports / expense list with expenses from this year and last year.
In English, this year's expenses show Aug 19 and older ones show Aug 19, 2025.
Switch to Spanish: 19 ago and 19 ago 2025.
Switch to Japanese: 8月19日 and 2025/08/19.
Open an expense and confirm the date on the detail page matches the list.

3. Calendar — first day of the week

Go to Settings > Profile > Personal details > Date of birth and open the date picker.
In English, the week starts on Monday (M T W T F S S).
Switch to Spanish, German, French: still start on Monday.
Switch to Japanese: the week now starts on Sunday.
Switch to Portuguese (BR): the week starts on Sunday.
In each language, check the weekday letters above the grid are in that language, and the dates line up under the correct weekday.

4. Calendar — month names

In the same date picker, tap the month/year to open the month list.
In Spanish the months read Enero, Febrero, Marzo… (capitalised here — this is a standalone list, so capitals are correct).
In French: Janvier, Février, Mars…. In German: Januar, Februar, März….

5. Date field placeholder

Settings > Profile > Personal details > Date of birth, with no date set yet.
In English the empty field shows MM/DD/YYYY.
Switch to German: DD.MM.YYYY. Japanese: YYYY/MM/DD.
Pick a date and confirm the filled-in value uses the same order and separators as the placeholder did.

6. Selected date must not shift by a day

Set the device timezone to a US timezone (behind UTC).
Settings > Profile > Personal details > Date of birth > pick a date, e.g. 15 June 1990.
The field must show the date you picked. Not the day before.
Save, leave the page, come back. It must still be the same date.
Repeat with Settings > Profile > Status > Clear after > Custom > Date.
Repeat with Workspace > Company cards > assign a card > Transaction start date.
Now set the device to an Asian timezone (ahead of UTC) and repeat steps 2–6.
Repeat the whole section with the app language set to Spanish and to Japanese.

7. Merging expenses must not crash

In a workspace chat, create two expenses and submit them.
Open the expense report and select both with the checkboxes.
From the dropdown choose Merge, pick any details, tap Next.
The app must not crash and the confirmation must show a readable date.
Switch to Spanish and repeat. The date must be a real date, not a bare number.

8. Split expense on Android

On Android, open an expense and choose Split.
The page must open normally, in English and again in Spanish.

9. "Last synced" text — needs iOS and Android

On iOS and on Android, go to Settings > Security > Device management.
Each device row shows a relative time, e.g. 2 hours ago / 3 days ago. It must not be empty.
Switch to Spanish: the same rows read hace 2 horas.
If you have a workspace with an accounting connection: Workspace > Accounting shows Last synced … — confirm it is not blank in both languages.

10. Travel and trip dates

Open a trip / travel booking in chat (flight, hotel, car or train).
Check the departure and arrival dates, the date range, and any cancellation deadline.
In Spanish and German confirm they use that language's date order.
Confirm no date range shows a dangling dash or a separator with nothing next to it (e.g. - 10:30).
Date ranges within one month should read Aug 17-20 in English and 17-20 ago in Spanish — the month must not sit between the two days.

11. Search filters

Open Search and apply a date filter with a custom range.
Check the filter chip label shows the range in the current language.
Switch language while the filter is still applied and confirm the chip updates to the new language.

12. Per Diem — including a previously reported save failure

Set the language to German.
Create a Per Diem expense, set a start and end time, and save it.
It must save. Previously German users got "Please choose a time that is at least one minute in the future" and could not save.
Open the saved expense and confirm the date range on it reads as German.
Repeat in Spanish and Japanese.

13. Other date surfaces

Confirm dates read in the selected language on:

Settings > Wallet — card details and statements
Settings > Subscription — billing dates and renewal date
Workspace > Workflows — monthly report submission day (e.g. "the 15th of each month")
Workspace > Expensify Card > Settings — settlement date
Profile page of another user — their local time, and confirm it updates on its own after a minute
Schedule a call flow — available time slots and the confirmation screen

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Mac-Chrome.mp4

melvin-bot · 2026-05-25T06:40:09Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2026-05-25T06:40:10Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

… Locale

codecov · 2026-05-25T09:23:40Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.85% <ø> (ø)`
src/Expensify.tsx	`85.36% <100.00%> (-0.47%)`	⬇️
...s/DatePicker/CalendarPicker/generateMonthMatrix.ts	`100.00% <100.00%> (ø)`
src/components/DatePicker/CalendarPicker/index.tsx	`96.57% <100.00%> (ø)`
src/components/DatePicker/index.tsx	`51.85% <100.00%> (-1.42%)`	⬇️
...s/LHNOptionsList/OptionRowLHN/OptionRow/Status.tsx	`47.05% <100.00%> (ø)`
...s/LHNOptionsList/OptionRowLHN/OptionRowLHNData.tsx	`88.00% <100.00%> (ø)`
...oneyRequestConfirmationList/sections/RateField.tsx	`80.00% <100.00%> (ø)`
src/components/OnboardingHelpDropdownButton.tsx	`96.07% <100.00%> (+0.42%)`	⬆️
...ponents/ReportActionItem/ChronosOOOListActions.tsx	`43.75% <100.00%> (ø)`
... and 138 more
... and 38 files with indirect coverage changes

…ation-dates-not-being-localized-correctly # Conflicts: # src/pages/Travel/FlightTripDetails.tsx

MelvinBot · 2026-05-26T18:03:21Z

PR Review

Well-executed migration from date-fns format strings to Intl.DateTimeFormat. The IntlStore / useSyncExternalStore architecture is clean, the useNow hook is correctly implemented, and locale threading is consistent across callers. A few items worth addressing:

Issues to fix

1. Mock type mismatch — src/languages/__mocks__/IntlStore.ts:7
The mock declares currentLocale: Locale | undefined while production now uses Locale (non-optional). This means getCurrentLocale() in the mock has an inferred return type of Locale | undefined, which doesn't match production. Tests could pass while incorrectly handling undefined. Change to Locale (no | undefined).

2. getStablePerDiemMerchantDateRange byte-stability concern — src/libs/DateUtils.ts
The comment says output "must stay byte-stable across user-locale changes." The locale is correctly pinned, but switching from format(date, 'MMM d, yyyy') (deterministic template) to Intl.DateTimeFormat('en', {dateStyle: 'medium'}) means output now depends on the platform's ICU version. iOS, Android, and web can produce subtly different strings (e.g., "Jun 5, 2025" vs "Jun. 5, 2025"). If this string is matched/compared on the backend, that's a problem.

3. datetimeToRelative still produces English-only output — src/libs/DateUtils.ts:256-260
This function accepts a locale parameter but never passes a date-fns locale to formatDistance. Relative strings like "12 minutes ago" are always English regardless of the user's locale. Pre-existing issue, but a notable omission given the PR's goal.

Suggestions (non-blocking)

4. SHORT_DATE vs SHORT_DATE_PADDED separator consistency
getLocalizedDatePlaceholder derives field ORDER from SHORT_DATE (dateStyle: 'short') but the actual display uses SHORT_DATE_PADDED ({year:'numeric', month:'2-digit', day:'2-digit'}). These can theoretically produce different separators in some locales (e.g., / vs .). Worth cross-locale testing.

5. CalendarPicker missing useMemo
monthNames, daysOfWeekLong, daysOfWeek at src/components/DatePicker/CalendarPicker/index.tsx are recalculated every render. Wrapping in useMemo with preferredLocale as dependency would avoid unnecessary array allocations.

6. getWeekStartsOn tests are ICU-dependent
The parameterized tests for ja and pt-BR expect Sunday-start via Intl.Locale.getWeekInfo(). If CI has small-icu Node builds, these fall back to Monday and fail.

What's done well

UTC anchoring via toUTCDate/toLocalDate prevents the classic date-only-string timezone shift bug
NNBSP stripping regex is precise — only targets space before AM/PM, preserving French/Slavic typography
useNow hook is textbook useSyncExternalStore: stable function references, ref-counted subscriptions, monotonic minute indices, correct cleanup
IntlStore race guard (monotonic load token) correctly handles rapid locale switches
zh-hans narrow weekday test guards against CJK narrow-name collision — excellent edge case coverage
Type narrowing from Locale | undefined → Locale throughout is safe now that IntlStore pre-seeds EN

situchan · 2026-05-26T18:05:55Z

@TaduJR you're missing native platform tests.

Please test various timezones (US timezone UTC-X, Asia timezone UTC+X)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e56f6b81c3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-05-26T18:10:26Z

Regression test cases:

Fix localization: dates not being localized correctly #69945 (comment)
Fix localization: dates not being localized correctly #69945 (comment)
Android - Expense-App crashes on opening split expense #76643
Profile - Selected date in the calendar is moved back by one day #76646
[Due for payment 2026-01-29] Bank - Date of birth field placeholder shows YYYY-MM-DD when the new format is MM/DD/YYYY #80011
[Due for payment 2026-01-29] Expense - App crashes when reaching merge confirm page #80013
[Due for payment 2026-01-29] Date - Wrong date (moved back by one day) displayed in date field #80024

…ation-dates-not-being-localized-correctly # Conflicts: # src/components/FrozenCardHeader.tsx # src/pages/Travel/TrainTripDetails.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64f6c4cb74

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-08-20T15:53:35Z

@codex review

…ation-dates-not-being-localized-correctly

MelvinBot · 2026-08-20T16:05:16Z

Regression hunt

Bottom line: No confirmed regressions. I ran a live web pass + a focused delta check at the current head (7dc3f22). Localized dates render correctly on every surface I could verify, the main-merge added no un-localized date call sites, and the two CI failures from my last review are fixed. The live test flagged two anomalies (a DOB-picker off-by-one and an inert language selector) — but both trace to test-harness click flakiness this session, not the code. They're worth a ~1-min manual confirmation.

✅ Verified clean

Chat/inbox timestamps render as real localized strings ("Today at 3:25 PM") — no raw i18n keys, no "Invalid Date", no blanks.
Calendar grid — weekday header M T W T F S S (Monday start for en) and cell weekday/date alignment are correct (ARIA labels matched the real calendar). The Fix localization: dates not being localized correctly #69945-class wrong-column bug is not reintroduced.
Delta since my last review (41de24c → 7dc3f22) is mostly a main merge. It added zero new display-date call sites (no new date-fns format(), no toLocale* date methods), the localization core files have no conflict markers, and en week-start is still pinned to Monday via a new override short-circuit in getWeekStartsOn.
The two CI failures I flagged last time are resolved: relativetimeformat was added to cspell.json, and the truncated-labels golden PNG was regenerated. That confirms the new "As of:" label localization visibly shifts that one chart (~511px) — but localizeVictoryChartLabelText only rewrites the As of: string, never chart data or axes, so it's cosmetic. Just sign off on the new render.

⚠️ Two live-test anomalies — likely harness, please spot-check

1. DOB picker appeared to save the next day. The tester clicked "Wednesday, August 15" and the field filled 08/16 (repro'd for 2007 and 1990). I could not reproduce this in code — the path is timezone-independent and correct:

onDayPressed saves the raw clicked day as yyyy-MM-dd.
The field renders it via formatToLocalizedShortDate → formatIntl(…, toUTCDate(value), 'UTC'), which pins the day in UTC regardless of device timezone.

So a click on that cell can only produce 08/15. The most plausible cause is a coordinate click landing on the adjacent cell — and in the same session the language-list rows were also unclickable (below), so the harness was struggling to hit list/grid targets. Worth a manual click-through to be sure, but this reads as a test artifact, not a code bug.

2. Language switch didn't take. Clicking Español (and other rows) had no effect while the panel's Back button did respond. Given the same row-click flakiness, I couldn't verify whether this is real. The locale-switch path (IntlStore.load + LocaleContextProvider) was verified sound in the earlier deep review, so please confirm a real switch manually (es should reorder dates, e.g. 19 ago 2025).

Evidence

DOB calendar: after selecting a day the field showed the next day (observed in test)

DOB field filled 08/16/1990 after clicking Aug 15 1990

DOB calendar (English): header M T W T F S S, alignment correct

Inbox chat: correctly localized "Today at 3:25 PM" timestamp

view run

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4387fb4992

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

MelvinBot · 2026-08-20T16:05:32Z

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

…ation-dates-not-being-localized-correctly # Conflicts: # src/pages/iou/request/step/DynamicIOURequestStepDistanceManual.tsx # src/pages/iou/request/step/IOURequestStepAmount.tsx # src/pages/iou/request/step/IOURequestStepDistanceGPS/index.native.tsx

TaduJR · 2026-08-21T07:32:14Z

@codex review

chatgpt-codex-connector · 2026-08-21T07:38:26Z

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 879a5caedb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-08-21T09:54:03Z

Please fix conflict before going off for weekend. Then I'll review during weekend

…ation-dates-not-being-localized-correctly

…guard with its callers

…ation-dates-not-being-localized-correctly

…te-range formatters

…ation-dates-not-being-localized-correctly # Conflicts: # cspell.json

TaduJR · 2026-08-22T19:39:28Z

@codex review

chatgpt-codex-connector · 2026-08-22T19:46:17Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 4acba89c64

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ation-dates-not-being-localized-correctly # Conflicts: # src/components/ReportActionItem/ChronosOOOListActions.tsx

TaduJR · 2026-08-24T10:08:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c5635e9d1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-08-24T10:35:29Z

@codex review

chatgpt-codex-connector · 2026-08-24T10:45:24Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: cf89381c9d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR added 7 commits May 24, 2026 16:29

fix: localization dates not being localized correctly

829d0c6

refactor: tighten locale plumbing (strict Locale, useSyncExternalStore)

5ff0be0

fix: locale-aware DOB placeholder, travel dates, and Spanish months

6eef97e

fix: useNow sleep/wake minute bucket + IntlStore load() race guard

21a9c88

fix: stuck translations-loading flag on invalidated locale load

e0b5ad3

fix: useNow stale-time flash on remount after idle

1e83f2a

fix: localize DatePicker selected value to match placeholder format

01790d2

TaduJR requested review from a team as code owners May 25, 2026 06:40

melvin-bot Bot assigned TaduJR May 25, 2026

melvin-bot Bot requested a review from situchan May 25, 2026 06:40

melvin-bot Bot requested review from heyjennahay and removed request for a team May 25, 2026 06:40

melvin-bot Bot removed the request for review from a team May 25, 2026 06:40

github-actions Bot reviewed May 25, 2026

View reviewed changes

Comment thread src/hooks/useNow.ts Outdated

TaduJR added 4 commits May 25, 2026 11:25

fix: IntlStore mock subscribe + cspell dictionary entries

3eb2e04

chore: drop foreign-locale getMonthNames assertions and cspell entries

17613f2

fix: drop unused mock param and fix test assertions exposed by strict…

c06354d

… Locale

refactor: name MS_PER_MINUTE constant in useNow

cef128f

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

e56f6b8

…ation-dates-not-being-localized-correctly # Conflicts: # src/pages/Travel/FlightTripDetails.tsx

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Comment thread src/components/LocaleContextProvider.tsx Outdated

TaduJR added 3 commits May 30, 2026 14:34

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

7c9672f

…ation-dates-not-being-localized-correctly # Conflicts: # src/components/FrozenCardHeader.tsx # src/pages/Travel/TrainTripDetails.tsx

fix: formatTravelDate timezone mismatch and per-diem byte stability

a878d3a

fix: thread preferredLocale into PolicyDistanceRateDetailsPage

33d71f5

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread src/languages/IntlStore.ts Outdated

fix: make the failure path ask the same question as the boot gate

4387fb4

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

ad81d38

…ation-dates-not-being-localized-correctly

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread ...nents/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/components/VictoryChartLabel.tsx Outdated

TaduJR added 2 commits August 21, 2026 05:57

fix: subscribe chart labels to the locale instead of reading it once

51ad6f3

TaduJR added 9 commits August 21, 2026 13:44

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

78a75af

…ation-dates-not-being-localized-correctly

fix: stop five wire-timestamp helpers relying on leniency

93f2afe

fix: localize the split-expense date range and align the date-string …

1e43d75

…guard with its callers

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

c11ad52

…ation-dates-not-being-localized-correctly

refactor: dedupe the location-permission predicate and tighten the da…

2c5e97c

…te-range formatters

fix: stop the schedule-call grouping crashing on a missing start time

7add978

fix: parse each schedule-call instant once instead of three ways

e2b063a

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

faa1faa

…ation-dates-not-being-localized-correctly # Conflicts: # cspell.json

fix: migrate the merged-in test call sites off dateFnsLocale

4acba89

Merge branch 'main' of https://github.com/TaduJR/App into fix-localiz…

7c5635e

…ation-dates-not-being-localized-correctly # Conflicts: # src/components/ReportActionItem/ChronosOOOListActions.tsx

chatgpt-codex-connector Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread src/libs/DateUtils.ts

fix: pluralize the split date range and guard Intl.ListFormat

cf89381

fix: pluralize the split date range and guard Intl.ListFormat

bb2db68

Uh oh!

Conversation

TaduJR commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. Chat message timestamps

2. Expense list dates

3. Calendar — first day of the week

4. Calendar — month names

5. Date field placeholder

6. Selected date must not shift by a day

7. Merging expenses must not crash

8. Split expense on Android

9. "Last synced" text — needs iOS and Android

10. Travel and trip dates

11. Search filters

12. Per Diem — including a previously reported save failure

13. Other date surfaces

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

Uh oh!

codecov Bot commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented May 26, 2026

PR Review

Issues to fix

Suggestions (non-blocking)

What's done well

Uh oh!

situchan commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

situchan commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TaduJR commented Aug 20, 2026

Uh oh!

MelvinBot commented Aug 20, 2026

Regression hunt

✅ Verified clean

⚠️ Two live-test anomalies — likely harness, please spot-check

Evidence

DOB calendar: after selecting a day the field showed the next day (observed in test)

DOB field filled 08/16/1990 after clicking Aug 15 1990

DOB calendar (English): header M T W T F S S, alignment correct

Inbox chat: correctly localized "Today at 3:25 PM" timestamp

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

MelvinBot commented Aug 20, 2026

Uh oh!

TaduJR commented Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 21, 2026

Uh oh!

situchan commented Aug 21, 2026

Uh oh!

TaduJR commented Aug 22, 2026

TaduJR commented May 25, 2026 •

edited

Loading

codecov Bot commented May 25, 2026 •

edited by github-actions Bot

Loading