Skip to content

Change all pre-endpoint product/version failures to ProductNotFoundError #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Discookie wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change all pre-endpoint product/version failures to ProductNotFoundError #4887

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6d98f
Change all pre-endpoint product/version failures to ProductNotFoundError
Discookie Jun 11, 2026
d8dc51d
Remove redundant logs
Discookie Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions web/server/codechecker_server/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,8 @@ def do_POST(self):
error_msg = \
"Requested CodeCheckerService on a " \
f"nonexistent product: '{product_endpoint}'."
LOG.error(error_msg)
raise ValueError(error_msg)
LOG.debug(error_msg)

@bruntib bruntib Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception handler prints this message to the debug log already. I think, this could be removed.

raise ProductNotFoundError(error_msg)

if product_endpoint:
# The current request came through a
Expand All @@ -501,9 +501,9 @@ def do_POST(self):
else:
LOG.debug("This API endpoint does not exist.")

@bruntib bruntib Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception handler prints this message to the debug log already. I think, this could be removed.

error_msg = f"No API endpoint named '{self.path}'."
raise ValueError(error_msg)
raise ProductNotFoundError(error_msg)
else:
raise ValueError(
raise ProductNotFoundError(
f"API version {major_version} not supported")

else:
Expand Down
Loading