Make module functions private in binary crates - #809
Merged
Conversation
Enet4
added
C-dictionary-builder
Enet4
approved these changes
Aug 5, 2026
Enet4
left a comment
Enet4
left a comment
Owner
There was a problem hiding this comment.
Looks OK. 👍 We may well try to follow that approach for binary crates from now on. Appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this issue is still open (rust-lang/rust#74970), it's better to change all
pubmodifiers in binary crates topub(crate). This change also helped uncover an unused enum variant.