Fix DICOM UL AE title field length validation - #798
Merged
Conversation
atlex00
marked this pull request as ready for review
June 22, 2026 22:36
atlex00
force-pushed
the
fix/ul-ae-title-wire-length
branch
from
June 22, 2026 22:42
14de7c1 to
bafda0f
Compare
atlex00
marked this pull request as draft
June 22, 2026 23:05
atlex00
marked this pull request as ready for review
June 22, 2026 23:16
atlex00
force-pushed
the
fix/ul-ae-title-wire-length
branch
from
June 23, 2026 00:45
43e86f8 to
c9b4e8b
Compare
atlex00
marked this pull request as draft
June 23, 2026 00:56
atlex00
marked this pull request as ready for review
June 23, 2026 13:28
atlex00
marked this pull request as draft
June 29, 2026 11:11
This comment was marked as resolved.
This comment was marked as resolved.
atlex00
force-pushed
the
fix/ul-ae-title-wire-length
branch
from
June 29, 2026 11:18
5930f1e to
67e94c7
Compare
atlex00
force-pushed
the
fix/ul-ae-title-wire-length
branch
from
June 29, 2026 11:24
67e94c7 to
75d9cdb
Compare
atlex00
marked this pull request as ready for review
June 29, 2026 11:35
Enet4
reviewed
Jul 18, 2026
Enet4
left a comment
Enet4
left a comment
Owner
There was a problem hiding this comment.
Thank you for working on this. The writer really ought to ensure that the output stays compliant when faced with bad input such as an invalid AE title.
I have only a small suggestion to implement before we proceed.
Enet4
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The A-ASSOCIATE writer encoded the Called/Calling AE titles and then called
resize(16, b' '). Invalid values slipped through: empty and all-space titles were written as the forbidden all-spaces field, and titles longer than 16 bytes were silently truncated.DICOM PS3.8 §9.3.2 defines both as fixed 16-byte fields where the all-spaces value is not allowed. This adds a shared writer helper that pads valid shorter titles to 16 bytes and returns
WriteError::InvalidFixedSizeTextFieldfor empty, all-space, or overlong titles, used for both A-ASSOCIATE-RQ and A-ASSOCIATE-AC.