Skip to content

Fix CCE caused by casting before checking (triggered by /velocity reload) #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UserNugget merged 1 commit into from
Jun 7, 2026
Merged

Fix CCE caused by casting before checking (triggered by /velocity reload) #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions plugin/src/main/java/net/elytrium/limboapi/injection/login/LoginListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,11 @@ public void hookInitialServer(PlayerChooseInitialServerEvent event) {

@SuppressWarnings("ConstantConditions")
public void hookLoginSession(GameProfileRequestEvent event) throws Throwable {
LoginInboundConnection inboundConnection = (LoginInboundConnection) event.getConnection();
// In some cases, e.g. if the player logged out or was kicked right before the GameProfileRequestEvent hook,
// the connection will be broken (possibly by GC) and we can't get it from the delegate field.
if (LoginInboundConnection.class.isAssignableFrom(inboundConnection.getClass())) {
// The connection is not always a LoginInboundConnection: LimboAPI re-fires a GameProfileRequestEvent in
// LoginTasksQueue#finish using the InitialInboundConnection delegate, and in some cases (e.g. if the player
// logged out or was kicked right before this hook) the connection may be broken. We must check the type
// before casting, otherwise we'd throw a ClassCastException instead of gracefully skipping it.
if (event.getConnection() instanceof LoginInboundConnection inboundConnection) {
// Changing mcConnection to the closed one. For what? To break the "initializePlayer"
// method (which checks mcConnection.isActive()) and to override it. :)
InitialInboundConnection inbound = (InitialInboundConnection) DELEGATE_FIELD.invokeExact(inboundConnection);
Expand Down
Loading