feat: add blimp_it italian grammar evaluation tasks - #3917
Open
cristianochesi wants to merge 2 commits into
Open
feat: add blimp_it italian grammar evaluation tasks#3917cristianochesi wants to merge 2 commits into
cristianochesi wants to merge 2 commits into
Conversation
Author
|
any chance to get the merge of the BLiMP-IT reviewed by end of the month? |
baberabb
requested changes
Aug 14, 2026
baberabb
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! A couple of blockers though, and I think both point at the tasks not having been run end-to-end yet:
_template_yamlsetsvalidation_split: train, butNeTSlab/BLiMP-ITonly has atestsplit.- 27 task YAMLs reference dataset_names with no matching HF configs. the same 27 not listed in _blimp_it.yaml. They look like superseded duplicates (
conversa_a_agreement_in_dpvsconversa_a_agreement_dp, etc.). Should those be deleted, or are the configs still to be uploaded? - Can you add a row to
lm_eval/tasks/README.md, with a short description as all the other tasks.
Can you do a --limit 10 run on any small model once the split is fixed? That'll confirm it end-to-end
- _template_yaml: validation_split: train -> test_split: test (dataset is test-only) - add target_delimiter: "" for parity with blimp_nl/turblimp - remove 27 superseded task YAMLs with no matching HF config (caused by minor naming issues in the config files, now all fixed; additional renaming applied for consistency) - add four macro-phenomenon subgroups under blimp_it, unweighted aggregation - add row to lm_eval/tasks/README.md and Groups/Tasks section to blimp_it/README.md
Author
|
Thanks for the check! I fixed all the issues you mentioned and also grouped the phenomena to improve the readability of the results. I confirmed with a small test (lm_eval --model hf --model_args pretrained=GroNLP/gpt2-small-italian --tasks blimp_it --limit 10 --device cpu --batch_size 8) that everything runs smoothly now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.