xpay: add traces for payments#9137
Open
Lagrang3 wants to merge 4 commits into
Open
Conversation
Produce traces (see common/trace.h) for every payment in order to gather statistics about the duration of a full payment execution. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Collaborator
Author
|
@cdecker, are these trace annotations useful? Do you think I should add more tags? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Produce traces (see common/trace.h) for every payment in order to gather statistics about the duration of a full payment execution.
xpay doesn't spend much time on computation itself. The runtime bottlenecks are always rpc calls to either
askreneor lightningd's pay primitives.The trace hierarchy here takes the following form:
xpay/fetchinvoice: stand alone trace for the operation of fetching the invoice if xpay receives a BIP353 address or an offer.xpay/payment: a whole payment->
xpay/getroutes: waiting foraskrene-getroutes,->
xpay/injectpaymentonion: waiting for the payment onion to return.