Support Magisk v20.2 SEPolicy API and fix bootloop by MlgmXyysd · Pull Request #431 · ElderDrivers/EdXposed

MlgmXyysd · 2020-01-04T05:56:16Z

Magisk v20.2 added a new API to add support for custom sepolicy rules to be applied in the pre-init phase [1,2].

This pull-request

Updates the Magisk installer script to the latest version [1]
Adds support for custom sepolicy rules [2]
Converts the install method to the new variant using customize.sh [3]
Fix OPPO Android P bootloop [5]
Fix SandHook npe [6]
Add stub app from https://github.com/ElderDrivers/EdXposedManager [7]

These rules are merged by Magisk and only applied once during the pre-init phase.

This should make the custom Magisk build obsolete (when using Magisk v20.2+).

[1] topjohnwu/Magisk@12fda29
[2] https://topjohnwu.github.io/Magisk/guides.html#sepolicyrule
[3] https://topjohnwu.github.io/Magisk/guides.html#magisk-module-installer
[4] #428
[5] wuxianlin@e009fa8
[6] asLody/SandHook#45
[7] ElderDrivers/EdXposedManager@56547eb

Thanks

- Convert install.sh to new customize.sh - Set SKIPUNZIP=1 and handle the extraction ourselves

No need for custom Magisk builds anymore.

- Add custom sepolicy rule - Add Riru version to log - No hardcoded EdXposed version - Magisk v20.2+ required - No beta

WiredLife · 2020-01-07T12:41:57Z

Is there a compiled version to install via magisk?
Thanks!

MlgmXyysd · 2020-01-07T12:43:47Z

@WiredLife https://t.me/EdXposed/43

New method: XposedBridge.log(String name, String text) XposedBridge.log(String name, Throwable t)

Mikanoshi · 2020-01-15T02:07:32Z

When was EdXposed Installer support dropped?
I also have the same error with 0.4.6.1_4497: #443
Framework works though.

MlgmXyysd · 2020-01-15T03:34:16Z

When was EdXposed Installer support dropped?
I also have the same error with 0.4.6.1_4497: #443
Framework works though.

Installer support dropped at 461bf58

re-install edxposed manager

Fix message

HpNoTiQ56 · 2020-01-31T08:16:48Z

What's included in Stub app and how to use it. I've compiled your last commit of Manager and I've got two APK : stub and release. Is it useful to pass S/N?

MlgmXyysd · 2020-01-31T08:18:35Z

@HpNoTiQ56 no, just a stub, for give a link to download EdXposed Manager, and prevent to use unofficial closed-source EdXposed Manager

Mikanoshi · 2020-01-31T15:13:20Z

Not if you have signature check disabled :) Anyway, do you really need an android support lib that makes apk almost 1MB just to show a dialog and open a link? Could be 50KB.

nift4 · 2020-02-08T07:54:46Z

Why is this not merged? I use the canary builds with this PR on my daily driver Android Q.

MlgmXyysd · 2020-02-08T08:01:52Z

Not if you have signature check disabled :) Anyway, do you really need an android support lib that makes apk almost 1MB just to show a dialog and open a link? Could be 50KB.

If I don't use appcompat, you'll only see Android 4. X style dialogs

MlgmXyysd · 2020-02-08T08:02:07Z

Why is this not merged? I use the canary builds with this PR on my daily driver Android Q.

not completed

nift4 · 2020-02-08T08:03:09Z

Oops

MlgmXyysd · 2020-02-19T06:29:45Z

TODO:
[x] Completed persist detection
[x] Stub app
[ ] Module activation scope [1]

[1] Talk about Xposed new concept (Chinese)

Change-Id: I8d31014abff1ed15919ab10604a90be52d96c3a6

MlgmXyysd · 2020-02-27T08:32:08Z

Not if you have signature check disabled :) Anyway, do you really need an android support lib that makes apk almost 1MB just to show a dialog and open a link? Could be 50KB.

Now removed appcompat

MlgmXyysd · 2020-02-27T08:32:45Z

*If no more issues about persist partition detection (or sepolicy.rule) are submitted, this PR will be merged on March 1, 2020.

…nto sepolicy

m0vie and others added 5 commits January 4, 2020 11:09

Update magisk installer script to latest version

2f26a0e

Use new Magisk installer method

aa347b0

- Convert install.sh to new customize.sh - Set SKIPUNZIP=1 and handle the extraction ourselves

Support Magisk 20.2 custom sepolicy.rule

188c8b6

No need for custom Magisk builds anymore.

Support Magisk v20.2 SEPolicy API

4b706d6

- Add custom sepolicy rule - Add Riru version to log - No hardcoded EdXposed version - Magisk v20.2+ required - No beta

Fix can't create prop

b91fccc

MlgmXyysd requested a review from solohsu January 4, 2020 06:24

Fix SEPolicy not work

ef8496d

MlgmXyysd commented Jan 4, 2020

View reviewed changes

Comment thread edxp-core/template_override/sepolicy.rule Outdated

MlgmXyysd added 4 commits January 6, 2020 20:12

Remove useless file

7470f6d

Support old Magisk

c0bd44c

Fix typo

ae02fa7

Format and bump version

795affa

Fix OPPO Android P from @wuxianlin

20fd9de

MlgmXyysd changed the title ~~Support Magisk v20.2 SEPolicy API~~ Support Magisk v20.2 SEPolicy API and fix OPPO Android P bootloop Jan 8, 2020

MlgmXyysd changed the title ~~Support Magisk v20.2 SEPolicy API and fix OPPO Android P bootloop~~ Support Magisk v20.2 SEPolicy API and fix bootloop Jan 9, 2020

MlgmXyysd added 11 commits January 10, 2020 16:40

Redirect to wiki

89275d3

Fix system app crash on Android Q

767c9bc

Add interface to disable modules log

461bf58

New method: XposedBridge.log(String name, String text) XposedBridge.log(String name, Throwable t)

Update description

68e0e28

Add support for Magisk Alpha2

d9c97cc

Fix bootloop caused by multiple reasons

e0cd2a5

Fix log clear failed

3df8845

Fix log cannot read

519c28c

Optimize installer display

7fedbe4

Remove useless log method

85be13a

Fix SandHook null pointer exception

4bcc4d4

MlgmXyysd added 5 commits January 29, 2020 23:30

Fix stub not include

be0f92c

Add support for devices not have persist

1898278

Fix message

Use app instead priv-app

03a148a

Leave mount info to log

454c7f3

Optimize persist check

b72968e

aviraxp and others added 3 commits February 26, 2020 11:51

Fix NPE in hookXposedInstaller()

11a644d

Update stub Manager app

60951a1

New test persist detection

61d985a

MlgmXyysd linked an issue Feb 27, 2020 that may be closed by this pull request

[BUG] v.0.4.6.x - No check/verify of sepolicy add could lead to bootloop #464

Closed

MlgmXyysd removed a link to an issue Feb 27, 2020

[BUG] v.0.4.6.x - No check/verify of sepolicy add could lead to bootloop #464

Closed

YAHFA: Support for android 10

a397f44

Change-Id: I8d31014abff1ed15919ab10604a90be52d96c3a6

MlgmXyysd added 4 commits February 28, 2020 10:53

Update stub prebuilt apk

247f14a

Merge branch 'sepolicy' of https://github.com/ElderDrivers/EdXposed i…

5471a41

…nto sepolicy

Optimize Riru-Core detection

7ed6190

Fix path context & Adapt to latest Riru

8131458

MlgmXyysd self-assigned this Feb 29, 2020

MlgmXyysd added the enhancement New feature or request label Feb 29, 2020

MlgmXyysd merged commit 7097267 into master Feb 29, 2020

MlgmXyysd deleted the sepolicy branch February 29, 2020 15:55

MlgmXyysd removed the request for review from solohsu March 1, 2020 03:25

Uh oh!

Conversation

MlgmXyysd commented Jan 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks

Uh oh!

Uh oh!

WiredLife commented Jan 7, 2020

Uh oh!

MlgmXyysd commented Jan 7, 2020

Uh oh!

Mikanoshi commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MlgmXyysd commented Jan 15, 2020

Uh oh!

HpNoTiQ56 commented Jan 31, 2020

Uh oh!

MlgmXyysd commented Jan 31, 2020

Uh oh!

Mikanoshi commented Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nift4 commented Feb 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MlgmXyysd commented Feb 8, 2020

Uh oh!

MlgmXyysd commented Feb 8, 2020

Uh oh!

nift4 commented Feb 8, 2020

Uh oh!

MlgmXyysd commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MlgmXyysd commented Feb 27, 2020

Uh oh!

MlgmXyysd commented Feb 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MlgmXyysd commented Jan 4, 2020 •

edited

Loading

Mikanoshi commented Jan 15, 2020 •

edited

Loading

Mikanoshi commented Jan 31, 2020 •

edited

Loading

nift4 commented Feb 8, 2020 •

edited

Loading

MlgmXyysd commented Feb 19, 2020 •

edited

Loading