-
Notifications
You must be signed in to change notification settings - Fork 2
ci/publish: node 24 + OIDC trusted publishing; drop EOL node 18 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c34e302
publish workflow: switch to OIDC trusted publishing on node 24
Shane98c 3d3195c
ci: support node 20-24 (drop EOL 18, add 24); set engines node >=20
Shane98c e93f726
docs: add RELEASING.md
Shane98c 95a5cd5
docs: note manual publish lacks provenance
Shane98c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Releasing | ||
|
|
||
| Publishing to npm runs in CI (`.github/workflows/publish.yaml`). | ||
|
|
||
| 1. `npm version <patch|minor|major>` — bumps `package.json`, commits, tags `vX.Y.Z`. | ||
| 2. `git push --follow-tags` | ||
| 3. `gh release create vX.Y.Z --generate-notes` — triggers the publish (the tag alone does not). | ||
| 4. CI installs, tests, builds, and publishes. Verify with `npm view icechunk-js version`. | ||
|
|
||
| Manual fallback: `npm ci && npm run build && npm publish --access public`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With npm OIDC trusted publishing enabled, manual publishing via
npm publishmay be restricted by npm's security settings (which often require publishing exclusively via CI/provenance). Additionally, manual publishing will not generate the secure build provenance. Consider adding a warning note about this limitation.