Skip to content

update icechunk to 0.6#671

Merged
TheJeran merged 3 commits into
mainfrom
la/ice_dot6
Jun 25, 2026
Merged

update icechunk to 0.6#671
TheJeran merged 3 commits into
mainfrom
la/ice_dot6

Conversation

@lazarusA

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the icechunk-js dependency to version ^0.6.0 and modifies tsconfig.json by removing the baseUrl configuration and updating path mappings. However, removing baseUrl will break compilation for files that use non-relative imports from node_modules, such as src/components/zarr/ZarrParser.ts. It is recommended to retain "baseUrl": "." to ensure successful module resolution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tsconfig.json
@lazarusA

Copy link
Copy Markdown
Member Author

@TheJeran I removed the baseUrl but I needed to remove the internal node_modules imports and copy over the 2 functions from zarrita instead, overall that's better than calling internal functions that might get deleted in the future.

@TheJeran

Copy link
Copy Markdown
Collaborator

No problem.

@TheJeran TheJeran merged commit 72393be into main Jun 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants