Skip to content

icechunk options into settings #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazarusA merged 2 commits into from
Jun 21, 2026
Merged

icechunk options into settings #669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b585cdf
mv into settings
lazarusA Jun 21, 2026
6ac9339
parse as int instead
lazarusA Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
262 changes: 141 additions & 121 deletions src/components/ui/MainPanel/RemoteIcechunk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ type Props = {

const RemoteIcechunk = ({ setInitStore, onOpenDescription }: Props) => {
const [url, setUrl] = useState('');

const [showSettings, setShowSettings] = useState(false);

const [refType, setRefType] = useState<RefType>('branch');
const [refValue, setRefValue] = useState('main');

Expand Down Expand Up @@ -169,143 +172,160 @@ const RemoteIcechunk = ({ setInitStore, onOpenDescription }: Props) => {
</Button>
</div>

{/* Branch / Tag / Snapshot */}
<div className="flex flex-wrap gap-2">
<div className="flex flex-1 gap-1">
{REF_TABS.map(({ value, label }) => (
<Button
key={value}
type="button"
variant={refType === value ? 'secondary' : 'ghost'}
size="sm"
className={`cursor-pointer flex-1 ${refType !== value ? 'text-muted-foreground' : ''}`}
onClick={() => setRefType(value)}
>
{label}
</Button>
))}
</div>
<Input
className="w-full"
placeholder={refType === 'branch' ? 'main' : refType}
value={refValue}
onChange={e => setRefValue(e.target.value)}
/>
</div>

{/* Storage options */}
{/* Settings toggle */}
<div>
<Button
type="button"
variant="ghost"
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer h-auto p-0"
onClick={() => setShowStorage(v => !v)}
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer"
onClick={() => setShowSettings(v => !v)}
>
{showStorage ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
Storage options
{showSettings ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
Settings
</Button>
Comment thread
lazarusA marked this conversation as resolved.
{showStorage && (
<div className="flex flex-col gap-2 mt-2">
<div className="flex gap-2">

{/* Credentials Select */}
<div className="flex flex-col gap-1 flex-1 text-xs">
<span className="text-muted-foreground">Credentials</span>
<Select
value={credentials || '__default__'}
onValueChange={v => setCredentials(v === '__default__' ? '' : v as Credentials)}
>
<SelectTrigger className="w-full text-xs h-8">
<SelectValue placeholder="Default" />
</SelectTrigger>
<SelectContent>
<SelectGroup>
<SelectItem value="__default__">Default</SelectItem>
{CREDENTIALS_OPTIONS.map(o => (
<SelectItem key={o.value} value={o.value}>{o.label}</SelectItem>
))}
</SelectGroup>
</SelectContent>
</Select>
</div>
{showSettings && (
<div className="flex flex-col gap-3 mt-2">

{/* Cache Select */}
<div className="flex flex-col gap-1 flex-1 text-xs">
<span className="text-muted-foreground">Cache</span>
<Select
value={cache}
onValueChange={v => setCache(v as Cache)}
{/* Branch / Tag / Snapshot */}
<div className="flex flex-col gap-2">
<div className="flex gap-1">
{REF_TABS.map(({ value, label }) => (
<Button
key={value}
type="button"
variant={refType === value ? 'secondary' : 'ghost'}
size="sm"
className={`cursor-pointer flex-1 ${refType !== value ? 'text-muted-foreground' : ''}`}
onClick={() => setRefType(value)}
>
<SelectTrigger className="w-full text-xs h-8">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectGroup>
{CACHE_OPTIONS.map(o => (
<SelectItem key={o.value} value={o.value}>{o.label}</SelectItem>
))}
</SelectGroup>
</SelectContent>
</Select>
</div>

{label}
</Button>
))}
</div>
<HeaderRows rows={storageHeaders} set={setStorageHeaders} />
<Input
className="w-full"
placeholder={refType === 'branch' ? 'main' : refType}
value={refValue}
onChange={e => setRefValue(e.target.value)}
/>
</div>
)}
</div>

{/* fetchClient headers */}
<div>
<Button
type="button"
variant="ghost"
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer h-auto p-0"
onClick={() => setShowFetchClientHeaders(v => !v)}
>
{showFetchClientHeaders ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
fetchClient headers
</Button>
{showFetchClientHeaders && (
<HeaderRows rows={fetchClientHeaders} set={setFetchClientHeaders} />
)}
</div>
{/* Storage options */}
<div>
<Button
type="button"
variant="ghost"
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer h-auto p-0"
onClick={() => setShowStorage(v => !v)}
>
{showStorage ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
Storage options
</Button>
{showStorage && (
<div className="flex flex-col gap-2 mt-2">
<div className="flex gap-2">

{/* Advanced */}
<div>
<Button
type="button"
variant="ghost"
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer h-auto p-0"
onClick={() => setShowAdvanced(v => !v)}
>
{showAdvanced ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
Advanced
</Button>
{showAdvanced && (
<div className="flex flex-wrap items-center justify-center gap-3 mt-2">
<div className="flex items-center gap-2 text-xs">
<label className="text-muted-foreground whitespace-nowrap">Max retries</label>
<Input
type="number"
className="w-16"
value={maxRetries}
onChange={e => setMaxRetries(Number(e.target.value))}
/>
</div>
<div className="flex items-center gap-2 text-xs">
<label className="text-muted-foreground whitespace-nowrap">Retry delay (ms)</label>
<Input
type="number"
className="w-20"
value={retryDelay}
onChange={e => setRetryDelay(Number(e.target.value))}
/>
</div>
{/* Credentials Select */}
<div className="flex flex-col gap-1 flex-1 text-xs">
<span className="text-muted-foreground">Credentials</span>
<Select
value={credentials || '__default__'}
onValueChange={v => setCredentials(v === '__default__' ? '' : v as Credentials)}
>
<SelectTrigger className="w-full text-xs h-8">
<SelectValue placeholder="Default" />
</SelectTrigger>
<SelectContent>
<SelectGroup>
<SelectItem value="__default__">Default</SelectItem>
{CREDENTIALS_OPTIONS.map(o => (
<SelectItem key={o.value} value={o.value}>{o.label}</SelectItem>
))}
</SelectGroup>
</SelectContent>
</Select>
</div>

{/* Cache Select */}
<div className="flex flex-col gap-1 flex-1 text-xs">
<span className="text-muted-foreground">Cache</span>
<Select
value={cache}
onValueChange={v => setCache(v as Cache)}
>
<SelectTrigger className="w-full text-xs h-8">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectGroup>
{CACHE_OPTIONS.map(o => (
<SelectItem key={o.value} value={o.value}>{o.label}</SelectItem>
))}
</SelectGroup>
</SelectContent>
</Select>
</div>

</div>
<HeaderRows rows={storageHeaders} set={setStorageHeaders} />
</div>
)}
</div>

{/* fetchClient headers */}
<div>
<Button
type="button"
variant="ghost"
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer h-auto p-0"
onClick={() => setShowFetchClientHeaders(v => !v)}
>
{showFetchClientHeaders ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
fetchClient headers
</Button>
{showFetchClientHeaders && (
<HeaderRows rows={fetchClientHeaders} set={setFetchClientHeaders} />
)}
</div>

{/* Advanced */}
<div>
<Button
type="button"
variant="ghost"
className="flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors cursor-pointer h-auto p-0"
onClick={() => setShowAdvanced(v => !v)}
>
{showAdvanced ? <ChevronUp size={12} /> : <ChevronDown size={12} />}
Advanced
</Button>
{showAdvanced && (
<div className="flex flex-wrap items-center justify-center gap-3 mt-2">
<div className="flex items-center gap-2 text-xs">
<label className="text-muted-foreground whitespace-nowrap">Max retries</label>
<Input
type="number"
className="w-16"
value={maxRetries}
onChange={e => setMaxRetries(Math.max(0, parseInt(e.target.value, 10) || 0))}
/>
</div>
<div className="flex items-center gap-2 text-xs">
<label className="text-muted-foreground whitespace-nowrap">Retry delay (ms)</label>
<Input
type="number"
className="w-20"
value={retryDelay}
onChange={e => setRetryDelay(Math.max(0, parseInt(e.target.value, 10) || 0))}
/>
</div>
Comment thread
lazarusA marked this conversation as resolved.
</div>
)}
</div>
</div>
)}
</div>

</div>
);
};
Expand Down
Loading