Remove committed uv.lock so the env resolves the latest ogcore#116
Open
SeaCelo wants to merge 1 commit into
Open
Remove committed uv.lock so the env resolves the latest ogcore#116SeaCelo wants to merge 1 commit into
SeaCelo wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 15 15
Lines 799 799
=======================================
Hits 626 626
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Collaborator
Author
|
@jdebacker its a great question and happy to apply either one. I thought of this approach because I dont see any good reason to lock to a specific ogcore version. That is something a user may want to do for a given paper/project (reproducibility). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv.lockwas committed automatically during the conda→uv migration, and it pinsogcoreto the migration-era 0.15.13. So the documented setup does not pull the latest ogcore — onmain,uv syncinstalls 0.15.13 (and even downgrades a newer install) even though 0.16.1 is released.This stops committing
uv.lock, souv syncresolves thepyprojectfloors freshly → latest compatible (ogcore 0.16.1today, new releases as they land).pyproject.tomlkeeps theogcore>=…floor for compatibility (what package consumers already use); the lock is regenerated locally and git-ignored.uv.lock, adds it to.gitignore, updates theAGENTS.mdconvention.uv syncnow resolvesogcore 0.16.1;pytest -m 'not local'passes (27).uv sync(no--frozen/--locked), so nothing breaks.cc: @rickecon @jdebacker
(Same change as OG-ETH #51.)