Fix session progress save on Windows - #8
Open
leo385 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix session progress persistence on Windows.
Session.save()currently usesPath.rename()to move the temporaryre-agent-progress.tmpfile overre-agent-progress.json.On Windows, this raises:
FileExistsError: [WinError 183]when the destination progress file already exists.
This changes
Path.rename()toPath.replace(), allowing the temporaryfile to replace the existing session file.
Reproduction
Reproduced on Windows 11 while running:
The first session write succeeds, but a subsequent write fails when
re-agent-progress.jsonalready exists.Changes
Path.rename()withPath.replace()Testing
Regression test:
Full test suite on Windows:
The 4 failures are unrelated existing Windows-specific test issues:
/bin/shis available