Metrics-related bug fixes#1680
Open
psilabs-dev wants to merge 5 commits into
Open
Conversation
psilabs-dev
marked this pull request as ready for review
July 16, 2026 03:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: The metrics leak that can span a couple months (resulting in a reported 100gb memory on grafana in a machine with only 96gb ram) is traced back to worker stats not being cleaned up on exit.
E.g.:
Any gauge metric reported by an exited worker poisons the actual metrics cache, because complete cleanup happens only on LRR start (which there is a reason why cleanup doesn't happen during LRR runtime).
Problem 2: Redis stores the metrics of dead workers, and the way we count total active workers is which PIDs are in the metrics cache. What that actually counts is all workers, dead or alive.
These two issues are addressed by an architectural tweak:
Additionally, the endpoints recorded by metrics are 3-months out of date, so this is updated (maybe Utils/Metrics.pm might do some parse-and-build of openapi.yaml so that we can dynamically handle this problem...).
In draft: todo pending on any non-mojo process that still needs lifecycle management.