Reader modernization step 2#1676
Open
siliconfeces wants to merge 4 commits into
Open
Conversation
siliconfeces
marked this pull request as draft
July 12, 2026 19:12
Contributor
Author
|
I just noticed some async issues have popped up again, some of my changes didn't mesh well with some previous fiddling with the double-page rendering. |
siliconfeces
marked this pull request as ready for review
July 12, 2026 20:12
Contributor
Author
|
Okay, so a lot of the issue was that I had repaired/preserved the function where a loading spinner appears if it takes more than 0.5s to load the image. That had broken earlier during some bug fixing, so things became weird. That spinner can appear again now, and I haven't managed to get the async issue to reappear. So, this PR is part preactification and part restoring the loading spinner. Double-page mode MIGHT be more efficient now as well, as both images are loaded concurrently now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electric bogaloo!
This step focuses on migrating the header/footer parts of the reader to preact, while touching up some code that ended up very related.
It also (somewhat/partially?) fixes the page 2 bug in #1675.