Registry and Plugin (Backend) by psilabs-dev · Pull Request #1511 · Difegue/LANraragi

psilabs-dev · 2026-04-06T06:33:47Z

Issue: Implement dedicated Plugin Repository #1146
Plugins demo registry repo: https://github.com/psilabs-dev/lrr-plugins-demo

Under testing, lots of code may be subject to change. There are quite a number of avenues where code might break. I don't recommend reviewing this code atm.

This backend-only PR ~~removes all (non-local) plugins from LRR~~, and implements the registry system and plugin management.

Multiple registry support
Management features, such as installing/uninstalling/upgrading plugins, plugin conflict resolution, management APIs.
Support for installing/uninstalling managed plugins
Redis is now responsible for plugin package presence management (previously INC's). Which makes uninstall/install easier.
~~Configuration-related features, such as metadata plugin priority, enablement, and dropdown hiding. Add metadata plugin priority support.~~

Obligatory security warning, as downloading untrusted arbitrary files and allowing code execution from the internet requires extra care which was not a consideration when plugins were the responsibility of LRR. The boundary for this PR is that LRR will not audit or review files/registries/licenses for the user, the user must trust registries and audit them personally/take responsibility for any bugs/vulnerabilities within plugins.

Some examples of ways to be compromised, which LRR cannot protect against: registry URL typos/typo squatting, DNS poison/certificate updates, hijacked registries/supply chain attacks

(tbh, with this I'm also just wondering whether plugin installations should require a restart altogether)

(PS: maybe we should support uninstalling sideloaded plugins?)

psilabs-dev · 2026-04-23T05:04:06Z

Updated this PR so it doesn't touch existing plugins, that's probably a separate concern to decide what to add/remove from LRR.

psilabs-dev · 2026-04-29T04:47:29Z

An update on duplicate plugins. There are many ways duplicates can happen with the entire plugin system, and the existing dev logic doesn't really handle it besides choosing a survivor and moving on. Now that a subset of plugins have crud, a duplicate does happen, then we might also run into myriad of other unforseen issues.

At the moment, I don't think this PR will guarantee graceful duplicate handling, or handling of issues caused by duplicate plugins.

LRR will perform plugin discovery on startup and report duplicates at warning level, and this PR will ensure that LRR plugin APIs do not introduce duplicates into the system. But past startup, LRR assumes a clean plugin state, and may not handle cases where a duplicate existed or is introduced by the user via other means.

(unless loc budget/complexity isn't a concern)

psilabs-dev · 2026-05-06T19:01:04Z

Removed channels in favor of semver, all registry plugin versions will be enforced at "x.x.x" style, and LRR will resolve installations by max semver version. Users can opt to install specific versions.

Added stack-based rollback on install failure. If LRR fails to upgrade a plugin, for example, it's going to attempt to restore the previous plugin (which is an existing stance iirc). This is a one-time rollback; if the rollback itself fails, then we're not going to "rollback the rollback", instead return 500 error.

Probably the (remaining) big item is where to place sideloaded plugins, I'll think about that after the local/git registry system is stable.

Commit history is mainly for tracking what's happened. Once the pr matures (after I do another pass), I'll do a rebase and squash.

psilabs-dev · 2026-05-10T02:52:58Z

The controller layer and OpenAPI contract are fixed, with exception of maybe some cosmetic changes but I won't be touching controller files anymore (unless something's really wrong). So this branch is free to api test.

Next up will be improving model/utils-side of things. A lot of the code is validation and exception handling work, not exactly business logic, but I'll have to see what exactly needs changing instead of just moving things around.

Guerra24

I don't see a way to list available plugins by registry, is it part of another pr or I'm just blind?

I have a feeling empty strings will cause issues in the api.

Code looks fine maybe a bit overly verbose at least compared to the rest.

I will do a second pass when I get to test it on Windows.

psilabs-dev · 2026-05-13T17:11:27Z

I don't see a way to list available plugins by registry, is it part of another pr or I'm just blind?

No this isn't added

psilabs-dev · 2026-05-13T22:28:18Z

One note: any request/response validation that can (and should) be done by OpenAPI won't be re-done by LRR. So this PR assumes that OpenAPI validation is enabled for any testing.

psilabs-dev · 2026-05-14T05:29:53Z

Removed the metadata plugin features as I think we already have enough to go over as is

psilabs-dev · 2026-05-14T08:41:51Z

basic cdn support is added

psilabs-dev · 2026-05-18T05:00:32Z

Model layer (and above) are now reviewable (assuming the tests pass). Next up will be improvements to the Utils-layer.

Guerra24

Looks fine to me, tested it on Windows and it works as expected. Model layer looks cleaner and is easier to follow.

psilabs-dev · 2026-05-26T17:46:30Z

The Utils layer (Plugin/PluginState/Registry) should be stable now. Going to start dogfooding on this with a gitlab/codeberg account + self hosted gitea.

Unit and integration tests are still AI written, maybe we'll go through another round of mutation testing before I open it up for review.

psilabs-dev · 2026-05-28T05:29:52Z

squashed, backup at https://github.com/psilabs-dev/LANraragi/pull/new/dev-registry/backend-backup

psilabs-dev · 2026-05-28T20:35:22Z

Checked that registry on self-hosted gitea can be read by LRR (after some cert/dns shenanigans).

psilabs-dev · 2026-06-15T21:41:44Z

Removed inter-worker plugin synchronization logic and added an /api/server/status endpoint which carries whether the server should restart.

Also moved plugin loadability out of process, so it doesn't contaminate the process INC cache via require. Should work on both windows via Karen's perl guarantees, and in unix via the Config approach.

psilabs-dev

dobfood round 2

Difegue

Just a few misc things, I think we can undraft this otherwise.

I think the needs_restart bits should be coordinated with #1673 since it feels like there's some overlap there. (At the very least, I suppose we should provide an API to restart the server)

Difegue · 2026-07-11T14:52:44Z

+[OpenAPI lanraragi-api](https://raw.githubusercontent.com/Difegue/LANraragi/refs/heads/dev/tools/openapi.yaml)
+{% endopenapi-operation %}
+
+{% openapi-operation spec="lanraragi-api" path="/plugins/installed/{plugin_namespace}" method="delete" %}


I think the endpoint would be more sensible if we dropped the /installed

Suggested change

{% openapi-operation spec="lanraragi-api" path="/plugins/installed/{plugin_namespace}" method="delete" %}

{% openapi-operation spec="lanraragi-api" path="/plugins/{plugin_namespace}" method="delete" %}

DELETE "/plugins/{plugin_namespace}" and GET "/plugins/{type}" are indistinguishable param-wise (wrt openapi), we can have either one or the other as the methods live under the same URL

Alternatively, we could lift the managed plugins to the "/plugins/installed" URL, e.g. for installing plugins

Difegue · 2026-07-11T14:57:26Z

 * [Tankoubon API](api-documentation/tankoubon-api.md)
 * [Stamps API](api-documentation/stamp-api.md)
 * [Plugin API](api-documentation/plugin-api.md)
+* [Registry API](api-documentation/registry-api.md)


I think we need a doc page for Registries, can't really only have the API here.

I suppose docs can wait until the frontend makes it in, but I think we should write up the concepts and the types of supported registries already.

(also an archi doc update for the new redis structures)

Added some, though not sure how the docs should be presented with the UI missing 🤔 also idk how technical the docs should be...

Difegue · 2026-07-11T15:41:29Z


            } elsif ( ref( $pluginfo->{parameters} ) eq 'HASH' ) {

-                # TODO: remove this line (and the ARRAY check above)


I get that this line is being removed because $namerds now also stores the registry information for the plugin, but we do still want to deprecate array parameters at some point... Maybe with the move to registries actually.

I'd say that's something we can do.

Also this block was removed bc it clears all plugin data on config save (including prov), but that might be unclear, so I just reverted to commenting the whole thing out.

Difegue · 2026-07-11T16:32:57Z

+    my ( $redis, $namespace ) = @_;
+
+    my $namerds = "LRR_PLUGIN_" . uc($namespace);
+    $redis->hdel(


If we deprecate array params, we could change this to just delete the namerds key outright, right?

Might be worth adding a TODO here if I'm not mistaken.

If we just delete the namerds key we would also nuke previous configurations/settings (like enabled for metadata). Which I'm personally fine with (users just need to reconfigure stuff and you're kinda asking for it by uninstalling), but this could be a UX decision.

psilabs-dev · 2026-07-12T04:55:14Z

I think the needs_restart bits should be coordinated with #1673 since it feels like there's some overlap there. (At the very least, I suppose we should provide an API to restart the server)

this probably depends on merge order (but weakly). This PR only signals whether LRR needs to restart, but hitagi actually provides (or should provide) the restart APIs which the client can act on.

Following servers like jenkins, LRR should not force a restart after installations, and instead advise the user to manually trigger one. It's only if this statement were reversed that we'll have two merge order cases to consider.

and add a comment

psilabs-dev · 2026-07-14T05:54:03Z

Moved default registry to ougi

remaining CI failure is addressed by #1677

psilabs-dev mentioned this pull request Apr 11, 2026

Registry and Plugin (Backend) psilabs-dev/LANraragi#111

Open

psilabs-dev force-pushed the dev-registry/backend branch from aa7d49f to 6aba20a Compare April 12, 2026 00:28

psilabs-dev force-pushed the dev-registry/backend branch 2 times, most recently from c01a4d1 to 91e3e10 Compare April 23, 2026 05:00

psilabs-dev force-pushed the dev-registry/backend branch from 90930c8 to cd86cf0 Compare April 26, 2026 07:25

Guerra24 suggested changes May 13, 2026

View reviewed changes

Guerra24 reviewed May 26, 2026

View reviewed changes

psilabs-dev force-pushed the dev-registry/backend branch from 0f66f44 to 551e1f7 Compare May 28, 2026 05:28

psilabs-dev commented Jun 15, 2026

View reviewed changes

Comment thread lib/LANraragi/Model/Plugins.pm Outdated

Comment thread lib/LANraragi/Utils/Registry.pm Outdated

psilabs-dev force-pushed the dev-registry/backend branch from 082e035 to 2c41b88 Compare June 20, 2026 02:20

Guerra24 mentioned this pull request Jun 26, 2026

Configuration and uploaded plugins reset after leaving the lanraragi unused for a long time #1621

Open

psilabs-dev force-pushed the dev-registry/backend branch 2 times, most recently from 9ceea30 to 6252a88 Compare June 28, 2026 23:52

psilabs-dev mentioned this pull request Jul 2, 2026

(Plugin) Rebuild plugin configuration and management UI psilabs-dev/LANraragi#110

Open

psilabs-dev force-pushed the dev-registry/backend branch from 6252a88 to dc79c1f Compare July 2, 2026 22:23

Guerra24 mentioned this pull request Jul 10, 2026

Add process manager #1673

Draft

Difegue requested changes Jul 11, 2026

View reviewed changes

psilabs-dev added 7 commits July 11, 2026 21:25

Plugin registry and plugin operations

369e774

do not promise support for ghe

0165038

Remove registry runtime synchronization logic (#115)

cf9e598

remove true/false usage

367970f

move restart_required to serverinfo

27cde30

set MAX_PLUGIN_FILE_SIZE to 1MB

fbfeeb1

remove gitlab support

51ed1b6

psilabs-dev force-pushed the dev-registry/backend branch from 59343c0 to 51ed1b6 Compare July 12, 2026 04:30

psilabs-dev added 8 commits July 11, 2026 22:12

remove gitlab from unit tests also

a7c0e9e

move plugin installation to minion

c51b242

update architecture docs for registry

c48d3a7

restore the redis->del block but comment it out

e0b0cbb

and add a comment

add some plugin registry documentation

4e073fc

oops windows

a3568ee

rename default registry to ougi (#118)

622da86

restore gh workflows

33a84db

psilabs-dev marked this pull request as ready for review July 14, 2026 05:52

psilabs-dev mentioned this pull request Jul 16, 2026

Staging (obviously don't merge) psilabs-dev/LANraragi#56

Draft

	{% openapi-operation spec="lanraragi-api" path="/plugins/installed/{plugin_namespace}" method="delete" %}
	{% openapi-operation spec="lanraragi-api" path="/plugins/{plugin_namespace}" method="delete" %}


		} elsif ( ref( $pluginfo->{parameters} ) eq 'HASH' ) {

		# TODO: remove this line (and the ARRAY check above)

Uh oh!

Conversation

psilabs-dev commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psilabs-dev commented Apr 23, 2026

Uh oh!

psilabs-dev commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psilabs-dev commented May 6, 2026

Uh oh!

psilabs-dev commented May 10, 2026

Uh oh!

Guerra24 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psilabs-dev commented May 13, 2026

Uh oh!

psilabs-dev commented May 13, 2026

Uh oh!

psilabs-dev commented May 14, 2026

Uh oh!

psilabs-dev commented May 14, 2026

Uh oh!

psilabs-dev commented May 18, 2026

Uh oh!

Guerra24 left a comment

Choose a reason for hiding this comment

Uh oh!

psilabs-dev commented May 26, 2026

Uh oh!

psilabs-dev commented May 28, 2026

Uh oh!

psilabs-dev commented May 28, 2026

Uh oh!

psilabs-dev commented Jun 15, 2026

Uh oh!

psilabs-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Difegue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psilabs-dev Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psilabs-dev commented Apr 6, 2026 •

edited

Loading

psilabs-dev commented Apr 29, 2026 •

edited

Loading

Guerra24 left a comment •

edited

Loading

psilabs-dev Jul 13, 2026 •

edited

Loading