fix(test): harness index worker must _Exit like the production worker#925
Merged
Conversation
The supervised-worker fast path deliberately skips the pipeline teardown (the OS reclaims the process wholesale) and pairs that with _Exit, which bypasses atexit/LeakSanitizer. The production worker in run_cli has both halves; the test binary's worker emulation (tf_maybe_run_index_worker) only had the first: it returned normally through main(), LeakSanitizer ran at exit, reported the intentionally unfreed pipeline and forced exit code 1 — so the supervisor read a healthy index as worker_failed and IDX832 went red on exactly the platforms whose ASan builds run a leak pass (all four Linux legs; macOS/Windows ASan have none). Reproduced and verified fixed in an ubuntu:22.04 arm64 container: reap outcome=clean, mcp suite 140/0. Mirror the production exit: deliver the response file, fflush, _Exit. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth and last dry-run blocker: the supervised-worker teardown skip pairs with _Exit (which bypasses LeakSanitizer) in production run_cli, but the test binary's worker emulation returned normally through main — LSan reported the intentionally-unfreed pipeline and forced exit 1, so the supervisor read a healthy index as worker_failed (IDX832 red on the four Linux legs only; macOS/Windows ASan run no leak pass).
Verified in an ubuntu:22.04 arm64 container (the failing condition): reap outcome=clean exit_code=0, mcp suite 140 passed / 0 failed. Local macOS suite and lint-ci green.