chore(client): test if upstream scap main builds#520
Closed
Detair wants to merge 1 commit into
Closed
Conversation
The Linux pipewire backend regression that required our Detair/scap fork may now be resolved upstream. Switch to upstream main HEAD (c03f15a) and rely on CI to verify cross-platform builds. Local verification is blocked by a pre-existing libspa-0.8.0 system header mismatch on the dev machine (spa_pod_builder has _address field instead of data/size). This is unrelated to scap and reproduces on clean scap clones too. CI's ubuntu-24.04 / macos-latest / macos-15-intel / windows-latest jobs will be the real verification. If all four build targets pass, this PR drops the Detair fork permanently. If any fail, revert and file an upstream PR with Detair's targeted fix. Refs spec docs/superpowers/specs/2026-04-11-security-audit-followups-design.md (Topic 3)
Owner
Author
Finding: upstream still broken on LinuxCI result (https://github.com/Detair/kaiku/actions/runs/24294543682):
Upstream evidence:
The Frame enum regression that motivated Next stepTopic 3 Step 2b applies: open a narrow upstream PR against Our |
Detair
added a commit
that referenced
this pull request
Apr 12, 2026
Replaces the placeholder "#TODO (or file an issue)" note with concrete tracking state after the 2026-04-12 re-check: - Upstream main HEAD (c03f15a) still fails Linux build — Frame enum regression unfixed (see closed PR #520 for the test run) - Upstream CapSoftware/scap#178 still open, no updates since 2025-10-26 - Issue #521 tracks periodic re-checks with the procedure No code change. When upstream publishes a release with the Linux fix, follow the re-check procedure in #521 to drop the git dep. Refs spec docs/superpowers/specs/2026-04-11-security-audit-followups-design.md (Topic 3)
Detair
added a commit
that referenced
this pull request
Apr 12, 2026
…#522) Replaces the placeholder "#TODO (or file an issue)" note with concrete tracking state after the 2026-04-12 re-check: - Upstream main HEAD (c03f15a) still fails Linux build — Frame enum regression unfixed (see closed PR #520 for the test run) - Upstream CapSoftware/scap#178 still open, no updates since 2025-10-26 - Issue #521 tracks periodic re-checks with the procedure No code change. When upstream publishes a release with the Linux fix, follow the re-check procedure in #521 to drop the git dep. Refs spec docs/superpowers/specs/2026-04-11-security-audit-followups-design.md (Topic 3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests whether upstream
CapSoftware/scapmain HEAD now compiles as avc-clientdependency. If CI passes, we can drop theDetair/scapfork permanently. If CI fails, the upstream fix is still missing and we'll need to open a narrow upstream PR.Context
Detair/scap@fix/linux-frame-enumwas created becausescap 0.1.0-beta.1shipped a Frame enum restructure (Frame::Video(VideoFrame::*)) without updating the Linux pipewire backend, breaking our build. The fork adapts linux/mod.rs + a Windows typo fix.Upstream
CapSoftware/scapmain has had activity since then. This PR points our dep at upstream commitc03f15a4631f40cd8d2e36807befb83b314cfeb7and lets CI verify across all four build targets.Local verification status
Blocked by a pre-existing
libspa v0.8.0system header mismatch on the dev machine —spa_pod_builderhas_addressfield wherelibspa-0.8.0Rust bindings expectdata/size. Reproduces on clean scap clones and does not touch scap's own code. CI's ubuntu-24.04 runners have a compatible libspa version.Expected outcomes
Detair/scapfork.4d1304e9.Test plan
Refs
🤖 Generated with Claude Code