refactor: Rewrite Pokemon generation - #1396
Merged
Merged
Conversation
DayKev
reviewed
Dec 6, 2025
innerthunder
force-pushed
the
refactor/pokemon-generation
branch
from
December 8, 2025 23:16
f5270b2 to
f675010
Compare
innerthunder
marked this pull request as ready for review
December 9, 2025 05:23
Co-Authored-By: NightKev <34855794+DayKev@users.noreply.github.com>
innerthunder
force-pushed
the
refactor/pokemon-generation
branch
from
December 9, 2025 05:41
427649f to
db81db1
Compare
DayKev
previously approved these changes
Dec 9, 2025
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
The constructors for
Pokemonand its subclasses are a mess. This is also a prerequisite for #1394.What are the changes from a developer perspective?
Pokemonconstructor's optional parameters have been consolidated into aPokemonOptionsinterface. It also accepts aPokemonin place of the options interface to create shallow copies of Pokemon. SubclassesPlayerPokemonandEnemyPokemonhave also been given similar treatment.EnemyPokemonconstructor.PokemonDatanow implementsPokemonOptions, meaning it can also be directly plugged intoPokemonconstructors.dataSourceconstructor parameter has been made obsolete, hence it not being included inPokemonOptions.Screenshots/Videos
How to test the changes?
Affected overrides may require playtesting. Unit tests are TBD
Checklist
main(such as a hotfix), has the game version been updated (pnpm update-version:patch/pnpm update-version:minor?betaas my base branchpnpm test:silent)pnpm test:create) or updated existing tests related to the PR's changes?