ai-rework: Add Matchup Score modifiers - #1365
Draft
innerthunder wants to merge 7 commits into
Draft
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The AI should now account for ongoing battle effects when evaluating whether it should switch Pokemon. These battle effects include:
Why am I making these changes?
Part of the AI Rework.
What are the changes from a developer perspective?
Pokemon.applyMatchupScoreModifiersto apply Matchup Score (MUS) modifiers outside of the normal damage/EAS-based scoring.BattlerTagandArenaTagto apply tag-specific MUS modifiers.For more information on the new MUS modifiers, see the "Misc. Score Modifiers" tab in the Effect Scores Sheet
How to test the changes?
pnpm typecheckpnpm depcruisepnpm test:silentNew unit tests are WIP.
Checklist
pnpm test:silent)pnpm test:create) or updated existing tests related to the PR's changes?