Skip to content

[Art] Update animations for curse, salt cure, quick guard, skitter smack - #1228

Draft
Tempo-anon wants to merge 2 commits into
betafrom
camArt
Draft

[Art] Update animations for curse, salt cure, quick guard, skitter smack#1228
Tempo-anon wants to merge 2 commits into
betafrom
camArt

Conversation

@Tempo-anon

@Tempo-anon Tempo-anon commented May 27, 2025

Copy link
Copy Markdown
Contributor

What are the changes the user will see?

Curse, Salt Cure, Quick Guard, Skitter Smack animations updated

Why am I making these changes?

Cam had changes here that they wanted merged

What are the changes from a developer perspective?

The json files were updated

Screenshots/Videos

How to test the changes?

const overrides = {
  MOVESET_OVERRIDE: [MoveId.CURSE, MoveId.SALT_CURE, MoveId.QUICK_GUARD, MoveId.SKITTER_SMACK]
}

Checklist

  • Otherwise: I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)

@Tempo-anon Tempo-anon added Move For move implementations/interactions Art / Graphics For issues/PRs related to graphics labels May 27, 2025
@Tempo-anon
Tempo-anon requested a review from pom-eranian May 27, 2025 19:16
@Snailman11

Snailman11 commented May 27, 2025

Copy link
Copy Markdown
Contributor

This PR addresses the following issues, please provide video of the fix working.

#698
[Bug] Skitter Smack User Disappears and Shadow Teleports During Move Animation

#485
[Sprite/Anim] Quick Guard animation offsets ally's sprite

PKR 5216
[Bug] Salt Cure and Curse Share an Animation, Animation Always Appears on Opponent's Side

  • I forgot to move this one over

@Snailman11

Copy link
Copy Markdown
Contributor

This PR addresses the following issues, please provide video of the fix working.

#698 [Bug] Skitter Smack User Disappears and Shadow Teleports During Move Animation

#485 [Sprite/Anim] Quick Guard animation offsets ally's sprite

PKR 5216 [Bug] Salt Cure and Curse Share an Animation, Animation Always Appears on Opponent's Side

  • I forgot to move this one over

Testing these and they don't seem to be fixed, but i'm not sure what this PR does

@flx-sta flx-sta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to validate that. I'll leave an approval so if @pom-eranian approves it to you have the 2 required ones

@MokaStitcher
MokaStitcher marked this pull request as draft June 3, 2025 21:15
@MokaStitcher

MokaStitcher commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Marking as draft until the PR description gets updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Art / Graphics For issues/PRs related to graphics Move For move implementations/interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants