Skip to content

Fixed bug for old versions of Windows #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pefedotov wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixed bug for old versions of Windows #167

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8c73bc7
Fixed the error of the library being unavailable on old versions of W…
pefedotov Jul 4, 2024
a98ad03
To avoid conflicts, concurrencpp.lib is appended with the letter 'd' …
pefedotov Jul 9, 2024
5aaa9df
The `result` class is now `[[nodiscard]]`.
pefedotov Jul 9, 2024
62e4ffb
wstring is not created if the condition is not met.
pefedotov Sep 24, 2024
fbe4f49
Missing include <string>
pefedotov Sep 24, 2024
e22acda
`#include <chrono>` fix
pefedotov Feb 21, 2025
a655cc4
`#include <string>` fix
pefedotov Feb 21, 2025
88b51a3
Merge pull request #1 from pefedotov/debug_lib_postfix
pefedotov Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/threads/thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,17 @@ size_t thread::hardware_concurrency() noexcept {
#ifdef CRCPP_WIN_OS

# include <Windows.h>
# include <VersionHelpers.h>

void thread::set_name(std::string_view name) noexcept {
const std::wstring utf16_name(name.begin(),
Copy link
Copy Markdown

@schneider92 schneider92 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making the wstring construction conditional too?

name.end()); // concurrencpp strings are always ASCII (english only)
::SetThreadDescription(::GetCurrentThread(), utf16_name.data());
if (IsWindowsVersionOrGreater(HIBYTE(_WIN32_WINNT_WIN10), LOBYTE(_WIN32_WINNT_WIN10), 14393)) {
// Windows 10 1607 or greater, use SetThreadDescription
::SetThreadDescription(::GetCurrentThread(), utf16_name.c_str());
} else {
// Windows version is less than Windows 10, do nothing
}
}

#elif defined(CRCPP_MINGW_OS)
Expand Down