-
Notifications
You must be signed in to change notification settings - Fork 15
Add css obfuscation test [APMSP-2764] #6648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Eldolfin
wants to merge
21
commits into
main
Choose a base branch
from
oscarld/add-css-obfuscation-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+434
−11
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8de63e3
Add CSS obfuscation test
Eldolfin 1a547c7
fix: fmt + don't assert the number of hits
Eldolfin 59964e3
feat: add tests for CSS obfuscation where agent version > sdk version
Eldolfin 7091a66
fix: assert header is >= 1 for later
Eldolfin f2423d9
fix: fmt
Eldolfin ae08cbb
feat: add css obfuscation test with config
Eldolfin be8a29c
fix: ci, rename obfuscation_disabled
Eldolfin 47c6904
fix: disabled test wrong env and quotes in values
Eldolfin cc4a3e2
fix: remove useless fixmes
Eldolfin 76be75f
fix: assert len(sql_stats) == 4
Eldolfin c5b16ba
fix: revert assert len(sql_stats) == 4 because they should be aggregated
Eldolfin b9fdb19
feat: add tests for obfuscation_version = 0 and missing
Eldolfin 35a38e2
fix: fmt
Eldolfin cb6da35
feat: enable css obfuscation tests for python
Eldolfin bd96e87
fix: fmt
Eldolfin 1fcdc3a
fix(ci): add new scenarios to run-end-to-end workflow
Eldolfin ad24599
fix: ci
Eldolfin e58ae7a
fix(manifests): disable css obfuscation tests for all but python
Eldolfin cf97552
fix: allow more than 4 entries when no obfuscation is done
Eldolfin e2c0e37
fix(stats): narrow SQL filter to avoid false positives from SQLite in…
Eldolfin 45e38cc
fix(stats): narrow SQL filter in obfuscation tests to exclude ORM que…
Eldolfin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this workflow section, the existing scenario steps use the default successful-previous-steps gating plus
!cancelled(), but these new steps addalways()and omit!cancelled(). GitHub Actions treatsalways()as a status override, so when an earlier scenario in this job fails or a run is cancelled, these obfuscation scenarios can still start instead of skipping like the surrounding scenario steps, wasting CI time and making cancellations less responsive. Use the samesteps.build.outcome == 'success' && !cancelled() && ...pattern unless these are intentionally post-failure cleanup steps.Useful? React with 👍 / 👎.