Bump Rust to 1.87, Clang/LLVM to 20#3926
Conversation
This is going to cause breakages with lints
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 7c680a3 | Docs | Datadog PR Page | Give us feedback! |
Benchmarks [ profiler ]Benchmark execution time: 2026-06-01 17:41:47 Comparing candidate commit 7c680a3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
morrisonlevi
requested review from
leoromanovsky and
typotter
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd12b023e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $config = $targets[$target] | ||
| $image = $config["Image"] | ||
| $dockerfile = $config["Dockerfile"] | ||
| $buildCommand = @("build", "--pull", "--no-cache", "-t", "$image", "-f", "$dockerfile") |
There was a problem hiding this comment.
Using docker-compose did not work? (not available or something?)
Disappointing to repeat the definitions here.
There was a problem hiding this comment.
Correct, no "docker compose" nor "docker-compose" at all, I checked both.
There was a problem hiding this comment.
https://docs.docker.com/compose/install/standalone#on-windows-server that's apparently the instructions to manually install
Trying.
There was a problem hiding this comment.
We can drop this too (vc14 is 7.0/7.1 only), and the vs14_buildtools.exe file too.
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Thanks for taking care of this.
leoromanovsky
left a comment
leoromanovsky
left a comment
There was a problem hiding this comment.
lgtm from ffe; looks like you are keeping all php version support ✔️
| Dockerfile = "Dockerfile" | ||
| BuildArgs = @("phpVersion=7.2.34", "vsVersion=vc15", "phpTarGzUrl=https://www.php.net/distributions/php-7.2.34.tar.gz", "phpSha256Hash=8b2777c741e83f188d3ca6d8e98ece7264acafee86787298fae57e05d0dddc78") | ||
| } | ||
| "php-7.1" = @{ |
There was a problem hiding this comment.
I noticed 7.0 and 7.1 are dropped from testing above. I assume we are dropping support; if so are these needed?
There was a problem hiding this comment.
I'll double check that I fixed them all, but we are not dropping any version support in this PR. What we are intentionally dropping is building 7.0/7.1 for Windows which isn't supported today, but we had various infrastructure around for it. So we are dropping that, because I wasted a nontrivial amount of time trying to get it to work, not realizing we didn't need it! I'm still pulling at the strings to delete everything related to 7.0/7.1, thanks for noticing this one!
However, an AI agent got too eager and deleted support from other platforms too and it slipped past initial review. I've at least partially fixed it, but I'll make sure that Alpine, CentOS, and our Bookworm images all have 7.0/7.1 support before merging.
5 participants
Description
This bumps some dependencies:
And also shrinks the bookworm images slightly:
Note that appsec is likely to require significant upgrades as they have not updated since Clang/LLVM 17. I'm working through them but expect it to take a while.
Misc Notes
DDCI_CONFIGURE_OTEL_EXPORTER: "true"is used when debugging docker buildx jobs, the job can somehow link to the buildx runner. I don't know how to do this, but the folks in our CI & Infra support folks do.Reviewer checklist