Skip to content

TB25 simulation analysis files#12

Open
AndreaPareti wants to merge 5 commits into
DRCalo:mainfrom
AndreaPareti:comparisonDataTB25
Open

TB25 simulation analysis files#12
AndreaPareti wants to merge 5 commits into
DRCalo:mainfrom
AndreaPareti:comparisonDataTB25

Conversation

@AndreaPareti

Copy link
Copy Markdown
Contributor

Added analysis files for tb25 simulations (analysis/tb25_analysis). These include channel mapping, FERS logic activation and noise.
Updated scripts for HTCondor submission.
Improved coordinate plotting in main analysis file (analysis/HidraAna.C)

Included (but currently commented out) geometry for 2026 test beam with SiPMs arranged in two columns with 6+4 configuration.

Separated horizontal and vertical rotations into two separate rotation matrices, in order to better describe platform rotation and calorimeter tilting.

Comment thread src/DREMTubesDetectorConstruction.cc
Comment thread analysis/tb25_analysis/C_sipm_std_run868_HG_4fers.csv
@lopezzot

Copy link
Copy Markdown
Member

Hi Andrea, just a few questions:

  • Have you rebased your branch on this main branch?
  • Have you run a global search for overlaps on the 2025 and 2026 geometries?
  • Why do you run the digitization directly in the simulation? Wouldn't it be better to save the time-of-arrival information from the simulation and then perform the SiPM digitization as a separate step?

@AndreaPareti

Copy link
Copy Markdown
Contributor Author

Ciao Lorenzo,
I tested the overlaps in previous versions on the geometry with the original hidra geometry. To be sure, I just run a global search with the TB25 geometry and all ancillaries, and did not find any overlap warning.

I have not rebased my own branch on the main repository one yet, as I did some other changes for my own studies. I preferred to keep the two separated to keep them clean.

I included the digitization in the simulation because I was worried about the size of the output files by storing each arrival time for each energy deposit. However, after some discussions and seeing the updates on the IDEA calo, I'm already working on separating the SiPM simulation and using it afterwards. I am planning to include the sensitive detector hits and the digitizer module in this repository once I reach a stable configuration.

@lopezzot

Copy link
Copy Markdown
Member

Ok seems fine.
Just one question on this:

I have not rebased my own branch on the main repository one yet, as I did some other changes for my own studies. I preferred to keep the two separated to keep them clean.

I don't fully understand what you mean with this. What I am asking is if your branch is alinged with this repository main branch (btw answer is it is not). That's because you forked from another fork. I suggest you rebase this branch (AndreaPareti:comparisonDataTB25) with this branch (DRCalo:main). If you don't do it we will never have a linear history on this repo and we might have conflicts in main branch. In short, your commits should be ahead of the last commit on this branch before merging.

@AndreaPareti

Copy link
Copy Markdown
Contributor Author

Sorry, I though you were referring to my other changes in my own repository for the sipm digitization inside the simulation. I have rebased the comparisonDataTB25 branch in the DRCalo/main repository. Is it OK now?

@lopezzot lopezzot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better now. Maybe someone else wants to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants