TB25 simulation analysis files#12
Conversation
|
Hi Andrea, just a few questions:
|
|
Ciao Lorenzo, I have not rebased my own branch on the main repository one yet, as I did some other changes for my own studies. I preferred to keep the two separated to keep them clean. I included the digitization in the simulation because I was worried about the size of the output files by storing each arrival time for each energy deposit. However, after some discussions and seeing the updates on the IDEA calo, I'm already working on separating the SiPM simulation and using it afterwards. I am planning to include the sensitive detector hits and the digitizer module in this repository once I reach a stable configuration. |
|
Ok seems fine.
I don't fully understand what you mean with this. What I am asking is if your branch is alinged with this repository main branch (btw answer is it is not). That's because you forked from another fork. I suggest you rebase this branch ( |
820001c to
5d793d1
Compare
|
Sorry, I though you were referring to my other changes in my own repository for the sipm digitization inside the simulation. I have rebased the comparisonDataTB25 branch in the DRCalo/main repository. Is it OK now? |
lopezzot
left a comment
There was a problem hiding this comment.
Yes, better now. Maybe someone else wants to review?
Added analysis files for tb25 simulations (analysis/tb25_analysis). These include channel mapping, FERS logic activation and noise.
Updated scripts for HTCondor submission.
Improved coordinate plotting in main analysis file (analysis/HidraAna.C)
Included (but currently commented out) geometry for 2026 test beam with SiPMs arranged in two columns with 6+4 configuration.
Separated horizontal and vertical rotations into two separate rotation matrices, in order to better describe platform rotation and calorimeter tilting.