fix: stripe payments can fail due to payment amount rounding mismatch#1348
Open
MrWeez wants to merge 1 commit into
Open
fix: stripe payments can fail due to payment amount rounding mismatch#1348MrWeez wants to merge 1 commit into
MrWeez wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Stripe webhook payment validation to avoid false cancellations when the stored payment total (in database units) rounds to a different minor-unit amount than the Stripe PaymentIntent reports.
Changes:
- Adjust Stripe webhook payload validation to compare amounts in Stripe minor units (e.g., cents) rather than converting Stripe amounts back into database units.
- Reuse the existing
convertAmount(...)logic for computing the expected Stripe amount from the storedPayment::total_price. - Remove the now-unused
convertGatewayAmountToDatabaseUnits(...)helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue where Stripe payments was marked as cancelled even if they was processed due to payment amount rounding mismatch during validation
Type of Change
Testing
Stripe was tested with exact same settings as user that reported this issue has and no error appeared
AI Assistance
Checklist
developmentbranchLegal
By submitting this pull request, I confirm that my contribution is made
under the terms of the project's
Contributor License Agreement
and that I have read and agree to the
Code of Conduct.