Frontend to allow changing email during signup - #9626
Open
nc225 wants to merge 3 commits into
Open
Conversation
Member
Other
|
9 tasks
nc225
marked this pull request as ready for review
August 25, 2026 18:30
nc225
requested review from
darrenvong,
nabramow and
papeldeorigami
as code owners
August 25, 2026 18:30
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the front end changes to close #9092. Backend changes are in this separate PR. This PR choose option 3 from this comment and lets users change their email at the email verification step.
On the design: I considered having the button to submit a new email address to the right of the text box instead of below it, but it seems like we usually put buttons below. I also considered having this all in a drop down accordion menu, but that didn't feel right for a single function. Very open to changing anything here, though.
Testing
(Note: Github's auto-checks on this repo will likely fail until the BE in #9627 is merged.)
I locally merged and ran both the frontend and backend branches, following all the steps in #9627 until "To run the backend tests..."
I went to localhost:3000 and tried a few different scenarios to break it, but everything worked as expected. I also added a few new frontend tests to check various scenarios and ran those frontend tests using



yarn test.Backend checklist
developif necessary for linear migration historyWeb frontend checklist
For maintainers