Skip to content

Fix centroid shift #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aguinot wants to merge 2 commits into
base: develop
Choose a base branch
from
+6 −4
Open

Fix centroid shift #725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7f495
Fix the centroid shift
aguinot May 10, 2026
dd1016e
The default size type is "T"
aguinot May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/shapepipe/modules/ngmix_package/ngmix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def get_last_id(self, cat_path):
if id_last != cat._cat_data[hdu_no].data["id"][-1]:
raise ValueError(
"Last ID {cat._cat_data[hdu_no].data['id'][-1]} in HDU"
+ f" #{hdu_no} inconsistent with {id_las}"
+ f" #{hdu_no} inconsistent with {id_last}"
)

return id_last
Expand Down Expand Up @@ -1026,16 +1026,18 @@ def do_ngmix_metacal(
# Gal guess
try:
gal_guess_tmp = get_guess(
gals[n_e], pixel_scale, guess_size_type="sigma"
gals[n_e],
pixel_scale,
guess_centroid_unit="img",
)
except Exception:
gal_guess_flag = False
gal_guess_tmp = np.array([0.0, 0.0, 0.0, 0.0, 1, 100])

# Recenter jacobian if necessary
gal_jacob = ngmix.Jacobian(
row=(gals[0].shape[0] - 1) / 2 + gal_guess_tmp[0],
col=(gals[0].shape[1] - 1) / 2 + gal_guess_tmp[1],
row=(gals[n_e].shape[0] - 1) / 2 + gal_guess_tmp[1],
col=(gals[n_e].shape[1] - 1) / 2 + gal_guess_tmp[0],
wcs=jacob_list[n_e],
)

Expand Down