Skip to content

Add boundary tests for IBC channel parameter validation #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
modernzju wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add boundary tests for IBC channel parameter validation #2510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions x/wasm/ibc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,38 @@ func TestMapToWasmVMIBCPacket(t *testing.T) {
}
}

func TestValidateChannelParams(t *testing.T) {
specs := map[string]struct {
channelID string
expErr bool
}{
"valid zero channel sequence": {
channelID: "channel-0",
},
"valid max uint32 channel sequence": {
channelID: "channel-4294967295",
},
"invalid channel sequence beyond uint32": {
channelID: "channel-4294967296",
expErr: true,
},
"invalid channel ID format": {
channelID: "invalid-channel",
expErr: true,
},
}
for name, spec := range specs {
t.Run(name, func(t *testing.T) {
err := ValidateChannelParams(spec.channelID)
if spec.expErr {
require.Error(t, err)
return
}
require.NoError(t, err)
})
}
}

func IBCPacketFixture(mutators ...func(p *channeltypes.Packet)) channeltypes.Packet {
r := channeltypes.Packet{
Sequence: 1,
Expand Down