fix: shell injection hardening, ERC-8004 link, npm/pnpm docs#348
Open
mithunbabbira wants to merge 1 commit into
Open
fix: shell injection hardening, ERC-8004 link, npm/pnpm docs#348mithunbabbira wants to merge 1 commit into
mithunbabbira wants to merge 1 commit into
Conversation
Escape npm package names and validate/escape cherry-pick hashes at execution time, tighten hostname SSRF literal checks, and point docs at the live EIP-8004 URL. Clarifies npm vs pnpm usage in the README. Closes Conway-Research#180 Closes Conway-Research#181 Closes Conway-Research#263 Closes Conway-Research#279 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_npm_package,install_mcp_server, andinstallNpmPackage(Security: Unescaped package names in npm install commands (CWE-78) #181)pull_upstreamcherry-pick commit hashes (Security: Unescaped commit hash in pull_upstream cherry-pick (CWE-78) #180)::ffff:/link-local/ULA addresses (partial Security: DNS rebinding bypass in SSRF protection (CWE-918) #183)Test plan
npm test -- src/__tests__/tools-security.test.ts src/__tests__/data-layer.test.ts(142 passed)gitrunsCloses #180
Closes #181
Closes #263
Closes #279
Made with Cursor