Do not retry SIWE /verify: single-use nonce masks the real error#333
Open
stevegonzalez721-ux wants to merge 1 commit into
Open
Conversation
The SIWE nonce is single-use; the server consumes it on the first /verify attempt. Because /verify runs through ResilientHttpClient with retries and 5xx is retryable, a server-side failure (observed: 500 "Database error" while persisting the session) triggers a retry that reuses the spent nonce and comes back as a misleading "401 Invalid or expired nonce". The true error is lost and provisioning looks like a client/nonce problem. Pass retries: 0 on the /verify call so the real verification error surfaces to the caller instead of being masked by a retry. Adds a ResilientHttpClient test that a retryable 5xx with retries:0 is returned directly without retrying. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Provisioning fails with a misleading
401 "Invalid or expired nonce", which points at the nonce/auth flow — but that is not the real cause.The SIWE nonce is single-use: the server consumes it on the first
/v1/auth/verifyattempt./verifyruns throughResilientHttpClient, which retries on 5xx. When the server returns a real error after the signature has already verified (observed:500 "Database error"while persisting the session), the client retries/verifywith the same, now-spent nonce. That retry comes back as401 "Invalid or expired nonce", and the original 500 is lost.Reproduction
Isolating the flow against
api.conway.tech(real wallet, real signature):/verifywith a garbage signature →400 "Verification failed"(nonce is found)/verifywith a valid signature →500 "Database error"(3/3 runs, consistent)So the nonce is valid and the signature verifies; the failure is server-side. Through the retrying client, that 500 surfaces to the user as a
401nonce error.Fix
Pass
retries: 0on the/verifyrequest. The nonce is single-use, so the call is not safe to retry — a retry can only reuse spent state and mask the true error. With this change, the real verification error (e.g. the 500) surfaces to the caller.Test
Adds a
ResilientHttpClienttest asserting that a retryable 5xx withretries: 0is returned directly, without retrying.🤖 Generated with Claude Code