fix: resolve search ranking showing N/A on admin page

[snomiao]

Summary

• The /nodes/search API endpoint doesn't return search_ranking in its response, causing all rankings to display as "N/A" on the admin search ranking page
• Added a NodeSearchRankingCell component that fetches each node's details via GET /nodes/{nodeId} (which returns search_ranking for authenticated admin users) to display actual ranking values
• Also fixed formatting to match project prettier config (single quotes, no semicolons)

Test plan

• Log in as admin and navigate to /admin/search-ranking
• Verify search ranking values now show actual numbers instead of "N/A" for nodes that have rankings set
• Verify editing a ranking still works correctly via the edit modal
• Verify pagination and search still work

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
registry-web	Ready	Preview, Comment	Apr 10, 2026 9:01am

[Copilot]

Pull request overview

Fixes the admin “Search Ranking Management” page showing N/A by rendering rankings via per-node detail fetches, working around /nodes/search not returning search_ranking.

Changes:

• Added NodeSearchRankingCell that calls useGetNode(nodeId) to display node.search_ranking per row.
• Updated the table to use the new cell instead of node.search_ranking from the search response.
• Reformatted pages/admin/search-ranking.tsx to match Prettier config (single quotes, no semicolons).

Comments suppressed due to low confidence (2)

pages/admin/search-ranking.tsx:162

• Node.id is optional in the generated API types, but this row uses it for both the React key and the detail Link URL. If a node ever comes back without an id, this will produce an invalid /nodes/undefined link and a non-unique/unstable key. Consider guarding the row rendering (or link) when node.id is missing and using a guaranteed-stable key fallback.

              <div>
                <Button size="xs" color="blue" onClick={() => handleEditRanking(node)}>
                  <MdEdit className="mr-1" /> {t("Edit")}
                </Button>
              </div>
            </li>
          ))}

          {/* Empty state */}
          {(!data?.nodes || data.nodes.length === 0) && (
            <li className="py-4 text-center text-gray-400">{t("No nodes found")}</li>

pages/admin/search-ranking.tsx:171

• NodeSearchRankingCell is invoked with nodeId={node.id || ''}. When node.id is absent this silently disables the query (because useGetNode is enabled: !!nodeId) and will always display N/A, which can mask data issues. Prefer handling the missing-id case explicitly (e.g., render N/A without instantiating the query, and avoid using an empty-string id that still creates a /nodes/ query key).

            currentPage={page}
            totalPages={data?.totalPages || 1}
            onPageChange={handlePageChange}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

useGetNode's second argument is params (querystring), not React Query options. Passing { staleTime, refetchOnWindowFocus } here will be sent as request params and the caching options won't apply. Move these under the 3rd argument as options: { query: { staleTime, refetchOnWindowFocus } } (and keep params as undefined unless needed).

Suggested change

	const { data: node, isLoading } = useGetNode(nodeId, {
	staleTime: 5 * 60 * 1000,
	refetchOnWindowFocus: false,
	const { data: node, isLoading } = useGetNode(nodeId, undefined, {
	query: {
	staleTime: 5 * 60 * 1000,
	refetchOnWindowFocus: false,
	},

[snomiao]

Fixed in 7e31cd5. Moved staleTime and refetchOnWindowFocus to the 3rd argument under options.query, and passed undefined for params. Also added enabled: !!nodeId to prevent queries with empty strings.

[Copilot]

This cell treats any useGetNode failure the same as “no ranking” (it will render N/A whenever the request errors, since node is undefined and isLoading is false). Consider handling isError/error separately (e.g., render an explicit error state or retry affordance) so network/auth issues aren’t silently masked as missing data.

Suggested change

	const { data: node, isLoading } = useGetNode(nodeId, {
	staleTime: 5 * 60 * 1000,
	refetchOnWindowFocus: false,
	});
	if (isLoading) return <Spinner size="xs" />;
	const { data: node, isLoading, isError } = useGetNode(nodeId, {
	staleTime: 5 * 60 * 1000,
	refetchOnWindowFocus: false,
	});
	if (isLoading) return <Spinner size="xs" />;
	if (isError) return <>Error</>;

[snomiao]

Fixed in 7e31cd5. Added isError handling that shows an explicit "Error" state instead of silently displaying N/A.

[Copilot]

Rendering NodeSearchRankingCell for each row introduces an N+1 pattern (up to 24 extra GET /nodes/{id} requests per page load/search/pagination). This can significantly slow the admin page and increase API load; consider adding search_ranking to /nodes/search for admin responses, or introducing a batch endpoint / query that fetches rankings for the current page in one request.

[snomiao]

Acknowledged the N+1 concern. The ideal fix is to extend /nodes/search to include search_ranking for admin responses on the backend. This approach is a workaround since the frontend can't modify the API response. Added staleTime: 5min and refetchOnWindowFocus: false (now correctly placed in query options per 7e31cd5) to mitigate repeated refetches.

[Copilot]

node.id is optional in the generated Node type; passing node.id || "" means the query will be disabled when id is missing and the cell will silently show N/A. Prefer guarding before rendering (e.g., only render the cell when node.id is truthy) so missing IDs are handled explicitly.

[snomiao]

Fixed in 7e31cd5. Now guarding node.id before rendering NodeSearchRankingCell — renders t("N/A") directly when id is missing, avoiding the empty-string query key issue.