docs: add Ideogram 4.0 tutorial video embed (EN/ZH/JA/KO)#1168
docs: add Ideogram 4.0 tutorial video embed (EN/ZH/JA/KO)#1168lin-bot23 wants to merge 1 commit into
Conversation
Embed the Ideogram 4.0 YouTube tutorial video in 8 files across tutorials/image/ideogram/ and tutorials/partner-nodes/ideogram/ for all 4 languages (EN/ZH/JA/KO).
📝 WalkthroughWalkthroughA YouTube iframe embed for the "Ideogram 4.0 Video Tutorial" is inserted into all eight locale variants (English, Japanese, Korean, Chinese) of the Ideogram v4 MDX tutorial pages, covering both the ChangesIdeogram v4 YouTube Embed (All Locales)
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tutorials/image/ideogram/ideogram-v4.mdx`:
- Around line 15-21: The iframe element is missing security and privacy
attributes required by the repo's established YouTube embed pattern. Add the
missing referrerpolicy attribute with value "strict-origin-when-cross-origin" to
control referrer data privacy. Expand the allow attribute list to include both
"autoplay" and "web-share" in addition to the existing permissions.
Additionally, align the styling approach with the repo's pattern by either
replacing the Tailwind className approach with inline style attributes (width:
"100%" and borderRadius: "0.5rem") or confirming that the Tailwind className
approach is now the standard across all embeds in the repo. Consider also adding
the frameborder="0" attribute for consistency with the established pattern in
the repository, even though it is deprecated in HTML5.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c3787c89-af98-4e7e-9069-4fa82a258c9d
📒 Files selected for processing (8)
ja/tutorials/image/ideogram/ideogram-v4.mdxja/tutorials/partner-nodes/ideogram/ideogram-v4.mdxko/tutorials/image/ideogram/ideogram-v4.mdxko/tutorials/partner-nodes/ideogram/ideogram-v4.mdxtutorials/image/ideogram/ideogram-v4.mdxtutorials/partner-nodes/ideogram/ideogram-v4.mdxzh/tutorials/image/ideogram/ideogram-v4.mdxzh/tutorials/partner-nodes/ideogram/ideogram-v4.mdx
| <iframe | ||
| className="w-full aspect-video rounded-xl" | ||
| src="https://www.youtube.com/embed/gO-D5eO8VlA?si=ehD_qzll3yCzirpP" | ||
| title="Ideogram 4.0 in ComfyUI" | ||
| allow="accelerometer; clipboard-write; encrypted-media; gyroscope; picture-in-picture" | ||
| allowFullScreen | ||
| ></iframe> |
There was a problem hiding this comment.
Missing referrerpolicy and incomplete allow list—deviates from repo's established YouTube iframe pattern.
The iframe is missing two security/privacy attributes present in the repo's standard YouTube embed (seen in registry/publishing.mdx:11-15):
referrerpolicy="strict-origin-when-cross-origin"– controls referrer data sent to YouTube- Missing permissions in the
allowlist:"autoplay"and"web-share"
Additionally, the repo's pattern uses inline style={{ width: "100%", borderRadius: "0.5rem" }} for layout; this code uses Tailwind className. If the codebase is transitioning to Tailwind, that's fine—but ensure consistency across the repo. Frameborder, while deprecated in HTML5, is also present in the repo's pattern and should be included for consistency.
🔒️ Proposed fix to align with repo's iframe pattern
<iframe
- className="w-full aspect-video rounded-xl"
+ style={{ width: "100%", borderRadius: "0.5rem" }}
src="https://www.youtube.com/embed/gO-D5eO8VlA?si=ehD_qzll3yCzirpP"
title="Ideogram 4.0 in ComfyUI"
+ frameborder="0"
- allow="accelerometer; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
+ allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
+ referrerpolicy="strict-origin-when-cross-origin"
allowFullScreen
></iframe>Alternatively, if the codebase uses Tailwind CSS, confirm this styling approach is consistent with other embeds in the repo and keep className, but do add the missing security attributes (referrerpolicy, expanded allow).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <iframe | |
| className="w-full aspect-video rounded-xl" | |
| src="https://www.youtube.com/embed/gO-D5eO8VlA?si=ehD_qzll3yCzirpP" | |
| title="Ideogram 4.0 in ComfyUI" | |
| allow="accelerometer; clipboard-write; encrypted-media; gyroscope; picture-in-picture" | |
| allowFullScreen | |
| ></iframe> | |
| <iframe | |
| style={{ width: "100%", borderRadius: "0.5rem" }} | |
| src="https://www.youtube.com/embed/gO-D5eO8VlA?si=ehD_qzll3yCzirpP" | |
| title="Ideogram 4.0 in ComfyUI" | |
| frameBorder="0" | |
| allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" | |
| referrerpolicy="strict-origin-when-cross-origin" | |
| allowFullScreen | |
| ></iframe> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tutorials/image/ideogram/ideogram-v4.mdx` around lines 15 - 21, The iframe
element is missing security and privacy attributes required by the repo's
established YouTube embed pattern. Add the missing referrerpolicy attribute with
value "strict-origin-when-cross-origin" to control referrer data privacy. Expand
the allow attribute list to include both "autoplay" and "web-share" in addition
to the existing permissions. Additionally, align the styling approach with the
repo's pattern by either replacing the Tailwind className approach with inline
style attributes (width: "100%" and borderRadius: "0.5rem") or confirming that
the Tailwind className approach is now the standard across all embeds in the
repo. Consider also adding the frameborder="0" attribute for consistency with
the established pattern in the repository, even though it is deprecated in
HTML5.
|
Closing — this is a founders interview/live stream, not a tutorial video, so it doesn't fit in the tutorial doc. |
1 participant
Embed the Ideogram 4.0 YouTube tutorial video into 8 documents across 2 tutorial paths in all 4 supported languages.
Files changed:
tutorials/image/ideogram/ideogram-v4.mdx(EN) — add Video Tutorial section before Workflowtutorials/partner-nodes/ideogram/ideogram-v4.mdx(EN) — samezh/tutorials/image/ideogram/ideogram-v4.mdx(ZH)zh/tutorials/partner-nodes/ideogram/ideogram-v4.mdx(ZH)ja/tutorials/image/ideogram/ideogram-v4.mdx(JA)ja/tutorials/partner-nodes/ideogram/ideogram-v4.mdx(JA)ko/tutorials/image/ideogram/ideogram-v4.mdx(KO)ko/tutorials/partner-nodes/ideogram/ideogram-v4.mdx(KO)