-
Notifications
You must be signed in to change notification settings - Fork 623
feat(assets): wire infinite scroll to the flat-output provider in the widget select dropdown #12780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattmillerai
merged 11 commits into
main
from
matt/fe-988-fe-wire-infinite-scroll-to-the-flat-output-provider-in-the
Jun 22, 2026
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cc04846
ci: add team-gated Cursor review (thin caller for github-workflows)
mattmillerai 4cadbb8
fix: resolve review feedback
mattmillerai e498c4a
ci: bump cursor-review SHA to github-workflows#9, drop judge_model ov…
mattmillerai 880582a
[automated] Apply ESLint and Oxfmt fixes
actions-user 8d23daa
fix: resolve review feedback
mattmillerai 1fee449
Merge branch 'main' into ci/cursor-review-workflow
mattmillerai 4136fcd
feat(assets): adopt cursor pagination in the flat-output infinite scroll
mattmillerai 9e3b738
test(assets): harden flat-output cursor coverage from review findings
mattmillerai 00fc87f
feat(assets): wire infinite scroll to the flat-output provider in the…
mattmillerai 8fcda26
Merge branch 'main' into matt/fe-988-fe-wire-infinite-scroll-to-the-f…
mattmillerai 96c8b0e
fix(assets): stop loadMore loop on all-seen pages; guard approach-end…
mattmillerai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Description: Team-gated multi-model Cursor review — a thin caller for the | ||
| # reusable workflow in Comfy-Org/github-workflows, which is the single source of | ||
| # truth for the panel, judge, prompts, and scripts. Triggered by the | ||
| # 'cursor-review' label. | ||
| # | ||
| # Access control (team-only, two layers): | ||
| # 1. Only users with triage permission or higher can apply a label in a public | ||
| # repo, so the public cannot trigger this. | ||
| # 2. The reusable workflow's secret-bearing jobs do not run on fork PRs (forks | ||
| # get no secrets), so CURSOR_API_KEY is reachable only on internal branches. | ||
| name: 'PR: Cursor Review' | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [labeled, unlabeled] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| # Re-labeling cancels an in-flight run for the same PR + label. | ||
| group: cursor-review-pr-${{ github.event.pull_request.number }}-${{ github.event.label.name }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| cursor-review: | ||
| if: github.event.action == 'labeled' && github.event.label.name == 'cursor-review' | ||
| # SHA-pinned per zizmor `unpinned-uses: hash-pin`. Bump this SHA to pick up | ||
| # upstream changes; keep `workflows_ref` matching so prompts/scripts load | ||
| # from the same commit as the workflow definition. | ||
| uses: Comfy-Org/github-workflows/.github/workflows/cursor-review.yml@047ca48febe3a6647608ed2e0c4331b491cb9d6a # github-workflows#9 | ||
| with: | ||
| # Overriding diff_excludes replaces the reusable default wholesale, so | ||
| # this restates the generated/vendored defaults and adds this repo's heavy | ||
| # paths (Playwright snapshots, generated manager types). | ||
| diff_excludes: >- | ||
| :!**/package-lock.json | ||
| :!**/yarn.lock | ||
| :!**/pnpm-lock.yaml | ||
| :!**/node_modules/** | ||
| :!**/.claude/** | ||
| :!**/dist/** | ||
| :!**/vendor/** | ||
| :!**/*.generated.* | ||
| :!**/*.min.js | ||
| :!**/*.min.css | ||
| :!**/*-snapshots/** | ||
| :!src/workbench/extensions/manager/types/generatedManagerTypes.ts | ||
| # Load the prompts/scripts from the same ref as `uses:`. | ||
| workflows_ref: 047ca48febe3a6647608ed2e0c4331b491cb9d6a | ||
| secrets: | ||
| CURSOR_API_KEY: ${{ secrets.CURSOR_API_KEY }} | ||
| # Optional — enables start/complete Slack DMs to the triggerer. | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): per the PR description, VueUse ≥14's
throttleFilter(leading=false)makesuseScroll'sthrottle: 64in VirtualGrid drop discrete mouse-wheel events, soapproach-endonly fires for high-frequency (trackpad-style) scrolling. That leaves this wiring effectively inert for mouse-wheel users until the separate throttle bug is fixed. Is the intent to land the (harmless-but-inactive) wiring ahead of that fix, or to stack the throttle fix first so FE-988 ships actually-working for everyone? Either is defensible — just flagging that on merge the feature is non-functional for a large share of users.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed on the wiring side:
@approach-endis debounced 300ms and guarded byhasMore/isLoadingMorebeforeloadMore(), with:loading-moredriving the spinner — correct in isolation and a no-op whenapproach-endnever fires. Your premise holds too: the event originates upstream inVirtualGrid'suseScroll({ throttle: 64 }), and theleading=falsewheel-event drop lives there, outside this diff.So this lands as-is: the mouse-wheel dormancy is a pre-existing
VirtualGridthrottle limitation that's tracked separately — not introduced or worsened by this PR, and trackpad scrolling works today. Not gating this change.