📝 docs(readme): correct exec-denial reasons and index the exec examples - #78
Conversation
- README.md: deny-all preset returns 403 "not allowed by portwing preset", not the with-exec preset's "exec denied: no commands are allowlisted"; clarify the denial reason now reaches portwing's exec error and the exec_end reason forwarded to the controller (drydock-side display pending) - examples/docker-compose.edge-with-exec.yml: same correction in the header comment, plus a pointer to sockguard's audited tri-tool bundle - examples/README.md: index docker-compose.edge-with-exec.yml and sockguard-with-exec.yaml, added in #77 but missing from the table - docs/content/docs/drydock-integration.mdx: document the exec_* Edge Mode message types and note exec_end's reason field
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdated documentation for sockguard exec-denial behavior and Edge Mode interactive exec protocol messages. The changes describe Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
sockguard.yamlpreset returns 403not allowed by portwing preset(not the with-exec preset'sexec denied: no commands are allowlisted); clarified that the denial reason now reaches portwing's exec error and is forwarded in theexec_endreason to the controller (drydock-side display still pending)examples/compose/tri-tool/bundledocker-compose.edge-with-exec.ymlandsockguard-with-exec.yaml(added in 🐛 fix(docker): surface proxy/daemon error bodies in exec errors #77, missing from the table)exec_*Edge Mode message types (exec_start/exec_ready/exec_input/exec_output/exec_resize/exec_end) and noted exec_end'sreasonfieldDocs-only, no CHANGELOG entry.
Test plan
git statusin the worktree shows only the four intended files changedChangelog
exec_end.exec_*messages andexec_end.reason.Concerns
exec_end.reasonbehavior remains accurate while Drydock does not yet display the reason.