Skip to content

Reset notification status on decision changes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtap-research merged 4 commits into from
Jul 27, 2026
Merged

Reset notification status on decision changes #42

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f260d1
Reset notification status when decision changes
mtap-research Jul 27, 2026
d6dff23
Test decision-change notification reset
mtap-research Jul 27, 2026
1172b1e
Canonicalize pending decision before status reset
mtap-research Jul 27, 2026
ab4f8a7
Cover terminal notification status resets
mtap-research Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google-apps-script/AdminSync.gs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ function adminUpdate_(sheet, payload) {
}

var normalized = adminValidateChanges_(changes);
var currentDecision = clean_(current[COL.FINAL_DECISION - 1]);
if (normalized.finalDecision !== currentDecision) {
normalized.notificationStatus = 'Not Sent';
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
sheet.getRange(rowNumber, COL.INTAKE_STATUS, 1, 9).setValues([[
normalized.intakeStatus,
sheetText_(normalized.reviewer1),
Expand Down
24 changes: 21 additions & 3 deletions scripts/test_sheets_sync.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,27 @@ assert.equal(acceptedRow[21], "Sent");
assert.equal(brevoRequests.length, 2, "acceptance notification must use the same Brevo path");
assert.equal(brevoRequests[1].body.subject, "[PBAST10] Abstract accepted — brevo-submission-1");

acceptedRow[19] = "Reject";
acceptedRow[20] = "None";
acceptedRow[21] = "Not sent";
const rejectionUpdate = JSON.parse(context.adminUpdate_(tracker, {
submissionId: "brevo-submission-1",
expectedFingerprint: context.adminFingerprint_(acceptedRow),
changes: {
intakeStatus: "Checked",
reviewer1: "",
reviewer1Decision: "",
reviewer2: "",
reviewer2Decision: "",
finalDecision: "Reject",
finalPresentationType: "None",
notificationStatus: "Sent",
notes: "",
},
}).body);
assert.equal(rejectionUpdate.ok, true);
assert.equal(
rejectionUpdate.row.notificationStatus,
"Not Sent",
"changing the final decision must reset a prior delivery status",
);
const rejection = callAppsScript({
action: "admin-rejection-email",
submissionId: "brevo-submission-1",
Expand Down
Loading