Skip to content

[automated] Update Lotus version in API tests#7035

Open
leshyatwork[bot] wants to merge 1 commit into
mainfrom
leshy/update-lotus-version
Open

[automated] Update Lotus version in API tests#7035
leshyatwork[bot] wants to merge 1 commit into
mainfrom
leshy/update-lotus-version

Conversation

@leshyatwork
Copy link
Copy Markdown
Contributor

@leshyatwork leshyatwork Bot commented May 12, 2026

Changes

  • Updates Lotus version in the JSON-RPC API tests to the latest release.

@leshyatwork leshyatwork Bot added the RPC requires calibnet RPC checks to run on CI label May 12, 2026
@leshyatwork leshyatwork Bot requested a review from a team as a code owner May 12, 2026 00:38
@leshyatwork leshyatwork Bot removed the request for review from a team May 12, 2026 00:38
@leshyatwork leshyatwork Bot added the RPC requires calibnet RPC checks to run on CI label May 12, 2026
@leshyatwork leshyatwork Bot requested review from akaladarshi and hanabi1224 May 12, 2026 00:38
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.30%. Comparing base (388dc34) to head (57f376a).
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388dc34...57f376a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akaladarshi
Copy link
Copy Markdown
Collaborator

akaladarshi commented May 12, 2026

We should hold off on this for now because filecoin-project/lotus#13610 is not part of the lotus new version yet and we have already merged the #7001

Hence the tests are failing.

@hanabi1224
Copy link
Copy Markdown
Contributor

@akaladarshi we could use a commit tag instead?

@akaladarshi akaladarshi force-pushed the leshy/update-lotus-version branch from 09c7a44 to bf877f8 Compare May 12, 2026 10:42
@akaladarshi akaladarshi enabled auto-merge May 12, 2026 11:19
hanabi1224
hanabi1224 previously approved these changes May 12, 2026
@akaladarshi akaladarshi added this pull request to the merge queue May 12, 2026
@LesnyRumcajs LesnyRumcajs removed this pull request from the merge queue due to a manual request May 12, 2026
@LesnyRumcajs
Copy link
Copy Markdown
Member

As discussed, it doesn't make sense to do manual changes unless needed. Let's wait for a proper release.

Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking

@leshyatwork leshyatwork Bot force-pushed the leshy/update-lotus-version branch 2 times, most recently from 5acb971 to be4982d Compare May 14, 2026 00:44
@LesnyRumcajs
Copy link
Copy Markdown
Member

The latest Lotus release didn't include this fix for some reason, so still blocked. https://github.com/filecoin-project/lotus/releases/tag/v1.36.0

@leshyatwork leshyatwork Bot force-pushed the leshy/update-lotus-version branch from be4982d to df0e49a Compare May 15, 2026 00:41
@leshyatwork leshyatwork Bot force-pushed the leshy/update-lotus-version branch from df0e49a to 57f376a Compare May 16, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI Status: DO NOT MERGE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants