fix(ci): disable PyPI attestations for reusable workflow - #1570
fix(ci): disable PyPI attestations for reusable workflow#1570goldmedal wants to merge 9 commits into
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…er#1541) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… C-2 Phase 2) (Canner#1542) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…entifier (Canner#1557) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…anner#1559) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…flow (Canner#1562) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
table_reference() now returns Option<&str> after wren-core-base changes, causing WASM build failures. Use unwrap_or_default() to maintain the same behavior (empty string fallback). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ease docs
- Change with_explicit_nulls(false) to true so nullable columns
serialize as {"amount": null} instead of being silently dropped
- Add wren-core-wasm to RELEASING.md publish workflow list
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PyPI attestation verification fails when publishing from a reusable workflow because the attestation certificate contains the parent workflow (release-please.yml) while the trusted publisher is configured with the reusable workflow (publish-wren-core-py.yml). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (63)
📝 WalkthroughWalkthroughThis PR introduces a new WebAssembly crate (wren-core-wasm) for browser-based Wren engine execution, upgrades DataFusion to v53, adds supporting npm publishing workflows, extends wren-core-py with new SessionContext methods, and implements a DataFusion connector for local file analysis. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
publish-wren-core-py.ymlcalled fromrelease-please.yml). The attestation certificate embeds the parent workflow ref but PyPI validates it against the trusted publisher's workflow, causing a mismatch.Ref: pypa/gh-action-pypi-publish#166
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores