Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

test(wren-core): add tests for analyze_with_url_tables and dequote_identifier - #1557

Merged
goldmedal merged 1 commit into
Canner:feat/wren-wasmfrom
goldmedal:test-url-tables
Apr 14, 2026
Merged

test(wren-core): add tests for analyze_with_url_tables and dequote_identifier#1557
goldmedal merged 1 commit into
Canner:feat/wren-wasmfrom
goldmedal:test-url-tables

Conversation

@goldmedal

Copy link
Copy Markdown
Contributor

Summary

  • Add 3 tests for analyze_with_url_tables: rejects non-file data sources, accepts omitted data source, and succeeds with LocalFile + real Parquet file
  • Add test_dequote_identifier covering edge cases: quoted/unquoted strings, empty string, single " (len < 2 panic guard), quoted URLs, partial quotes

Test plan

  • All 4 new tests pass locally
  • Full test suite (78 tests) passes
  • cargo clippy --all-targets --all-features -- -D warnings clean

🤖 Generated with Claude Code

@github-actions github-actions Bot added documentation Improvements or additions to documentation core ibis dependencies Pull requests that update a dependency file rust Pull requests that update Rust code python Pull requests that update Python code labels Apr 14, 2026
@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2d88f88-b325-4ea4-88a3-b4e802afc1ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@goldmedal
goldmedal changed the base branch from main to feat/wren-wasm April 14, 2026 15:57
…entifier

Cover the URL table analysis path: data source rejection (non-file),
omitted data source acceptance, and successful local Parquet file
registration. Also test dequote_identifier edge cases including the
len < 2 panic guard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@goldmedal
goldmedal merged commit 2e0e865 into Canner:feat/wren-wasm Apr 14, 2026
3 checks passed
@goldmedal
goldmedal deleted the test-url-tables branch April 14, 2026 16:00
goldmedal added a commit to goldmedal/wren-engine that referenced this pull request Apr 16, 2026
…entifier (Canner#1557)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
goldmedal added a commit to goldmedal/wren-engine that referenced this pull request Apr 16, 2026
…entifier (Canner#1557)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation ibis python Pull requests that update Python code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant