This repository was archived by the owner on May 7, 2026. It is now read-only.
test(wren-core): add tests for analyze_with_url_tables and dequote_identifier - #1557
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
goldmedal
force-pushed
the
test-url-tables
branch
from
April 14, 2026 15:57
d885743 to
e9b5352
Compare
…entifier Cover the URL table analysis path: data source rejection (non-file), omitted data source acceptance, and successful local Parquet file registration. Also test dequote_identifier edge cases including the len < 2 panic guard. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
goldmedal
force-pushed
the
test-url-tables
branch
from
April 14, 2026 16:00
e9b5352 to
b8994a5
Compare
goldmedal
added a commit
to goldmedal/wren-engine
that referenced
this pull request
Apr 16, 2026
…entifier (Canner#1557) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
goldmedal
added a commit
to goldmedal/wren-engine
that referenced
this pull request
Apr 16, 2026
…entifier (Canner#1557) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analyze_with_url_tables: rejects non-file data sources, accepts omitted data source, and succeeds withLocalFile+ real Parquet filetest_dequote_identifiercovering edge cases: quoted/unquoted strings, empty string, single"(len < 2 panic guard), quoted URLs, partial quotesTest plan
cargo clippy --all-targets --all-features -- -D warningsclean🤖 Generated with Claude Code