Make the output of sys/conf/newvers.sh more stable. - #2651
Open
qwattash wants to merge 1 commit into
Open
Conversation
If the output from $CC -v contains the word 'version' in other lines, the resulting version string will contain newlines. As a result, the generated vers.c compiler_version string will be broken up by newlines and generate a compiler error. This does not further filter the $CC -v output, but ensures that newlines are escaped, so that the resulting C-string is legal.
bsdjhb
reviewed
May 27, 2026
bsdjhb
left a comment
bsdjhb
left a comment
Collaborator
There was a problem hiding this comment.
Hmmm, can you describe a case where this makes a difference? For all the compilers I have to hand on my FreeBSD desktop this doesn't make any change in the output.
Collaborator
|
Oops, I see that your commit comment does describe the case, not sure why that wasn't in the default PR description. I do think an upstream PR would be great as I'd rather the change be upstream if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I should just PR it upstream directly?