Skip to content

Use DELETE for delete view #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomneep wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use DELETE for delete view #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agate/agate/tests/test_api_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def test_delete_ingestion_attempt(self):
self.assertFalse(response.json()["archived"])

# Now delete the object
response = self.client.get(reverse("agate:delete", args=["user4"]))
self.assertEqual(response.status_code, status.HTTP_200_OK)
response = self.client.delete(reverse("agate:delete", args=["user4"]))
self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)

# Check that we can no longer find it (because it has been deleted)
response = self.client.get(reverse("agate:single", args=["user4"]))
Expand Down
4 changes: 2 additions & 2 deletions agate/agate/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ def archive_ingestion_attempt(request, uuid=""):
return HttpResponse(status=status.HTTP_200_OK)


@api_view(["GET"])
@api_view(["DELETE"])
def delete_ingestion_attempt(request, uuid=""):
obj = get_object_or_404(IngestionAttempt, uuid=uuid)

auth = request.headers.get("Authorization")
check_authorized(auth, obj.site, obj.project)
obj.delete()
return HttpResponse(status=status.HTTP_200_OK)
return Response(status=status.HTTP_204_NO_CONTENT)


def projects(request):
Expand Down