session server BUGFIX allow binding on missing address#606
Merged
Conversation
michalvasko
requested changes
May 25, 2026
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
I do not have an issue with using this option, generally, but perhaps it should not be used by default. If you make a typo in the address in the configuration, it may result in much more difficult debugging. Also, there may be compatibility issues and this option not supported on all the platforms so it may be worth adding a new check to cmake.
michalvasko
requested changes
May 25, 2026
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
Thanks for the improvements but I would appreciate if, in case the feature is enabled, the availability of the socket option is also checked in cmake. Should be fairly simple.
jktjkt
reviewed
May 25, 2026
michalvasko
approved these changes
May 25, 2026
michalvasko
requested changes
May 25, 2026
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
Looks good, thanks. Just a minor formatting issue.
Add a cmake option to use IP_FREEBIND/IPV6_FREEBIND options. Use the IP_FREEBIND/IPV6_FREEBIND on the socket to allow the bind even if the address is not ready. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
michalvasko
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the IPPROTO_IP/IPPROTO_IPV6 on the socket to allow the bind even if the address is not ready.