fix(module): send toggle event outside game#8574
Open
JoshuaRVLS wants to merge 1 commit into
Open
Conversation
Member
|
The fix is straight up bad. Please look into the code and not just add it into [ModuleRequest] which is not supposed to trigger any events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures REST module toggles also notify websocket listeners when the client is not in-
game.
Details
ClientModule.onToggledskips the normal event path outside a world, but the RESTtoggle endpoint can still update the module state there. This sends
ModuleToggleEventfrom the REST handler for that case so ClickGUI and other UIlisteners stay in sync.