fix(multiplayer): add LAN server detection for custom theme#8554
Merged
MukjepScarlet merged 9 commits intoJul 12, 2026
Conversation
- Add UDP multicast listener (224.0.2.60:4445) for LAN world broadcasts - REST endpoint GET /api/v1/client/servers/lan - LAN servers use negative IDs to avoid collision with regular servers - Auto-prune stale servers after 15 seconds (TTL) - Frontend polls every 3 seconds with error handling - Show 'LAN' tag on detected servers - Hide Remove/Edit buttons for LAN servers (not editable) - Disable sorting when LAN servers are present - Shutdown hook to cleanup socket on client close
Pro0101-2b2fr
force-pushed
the
fix/lan-server-discovery
branch
2 times, most recently
from
cfdb529 to
ec83b8a
Compare
MukjepScarlet
requested changes
Jun 24, 2026
- Replace custom UDP multicast implementation with vanilla LanServerDetection.LanServerDetector and LanServerList - Replace Runtime.addShutdownHook with ClientShutdownEvent handler to follow LiquidBounce's event system pattern - Remove redundant imports (DatagramPacket, InetAddress, MulticastSocket)
Pro0101-2b2fr
force-pushed
the
fix/lan-server-discovery
branch
from
ec83b8a to
6c9b56e
Compare
MukjepScarlet
requested changes
Jun 25, 2026
Replace manual JsonObject construction with interopGson.toJsonTree(serverData) to use the existing ServerInfoSerializer, as suggested in code review.
…List - Use call.respond(ActiveServerList.getLanServers()) directly - Move getLanServers() endpoint before ActiveServerList object, after other endpoints as requested in code review
MukjepScarlet
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add LAN world detection to the custom theme multiplayer screen, matching vanilla Minecraft behavior.
Changes
GET /api/v1/client/servers/lanFeatures
Testing
Here is a screenshot :
This PR was developed with AI assistance.