Skip to content

[model] feat: Add SDPA fallback for BAGEL NPU attention - #1027

Merged
Crystal-jiang merged 1 commit into
ByteDance-Seed:szl.omni_v2from
Crystal-jiang:bagel_npu_precision
Aug 7, 2026
Merged

[model] feat: Add SDPA fallback for BAGEL NPU attention#1027
Crystal-jiang merged 1 commit into
ByteDance-Seed:szl.omni_v2from
Crystal-jiang:bagel_npu_precision

Conversation

@Crystal-jiang

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add SDPA fallback for NPU attention in BagelSiglipAttention, controlled by ops_implementation.attn_implementation. Add _supports_sdpa flag to all 5 bagel modules.

Checklist Before Starting

  • Search for relative PRs/issues and link here: ...
  • PR title follows [{modules}] {type}: {description} format (enforced by check_pr_title.yml)
    • Allowed modules: agent, ci, ckpt, config, data, dist, docker, docs, logging, lora, misc, model, omni, optim, ops, parallel, perf, release, task, trainer
    • Allowed types: feat, fix, refactor, chore, test
    • Breaking changes: prepend [BREAKING] — e.g. [BREAKING][parallel, model] feat: dynamic batching

Test

Validation results (training curves, eval metrics) for changes not covered by CI.

API and Usage Example

Show API changes and usage examples if applicable.

Design & Code Changes

High-level design description and specific change list.

Checklist Before Submitting

  • Read the Contribute Guide
  • Applied pre-commit checks
  • Added/updated documentation
  • If tasks/ training scripts were moved or renamed: updated docs/ examples and verified python3 scripts/ci/check_doc_task_paths.py passes (also enforced by the Check doc task paths CI workflow)
  • Added tests to CI workflow (or explained why not feasible)

…P on NPU

Add SDPA fallback for NPU attention in BagelSiglipAttention, controlled by ops_implementation.attn_implementation. Add _supports_sdpa flag to all 5 bagel modules.
@github-actions github-actions Bot added the ascend everything about Ascend support label Aug 7, 2026
@Crystal-jiang
Crystal-jiang marked this pull request as ready for review August 7, 2026 07:04
@Crystal-jiang
Crystal-jiang merged commit d05e32e into ByteDance-Seed:szl.omni_v2 Aug 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ascend everything about Ascend support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants