Skip to content

Hint dropped courses - #39

Open
wznmickey wants to merge 9 commits into
BoYanZh:masterfrom
wznmickey:hintDroppedCourses
Open

Hint dropped courses#39
wznmickey wants to merge 9 commits into
BoYanZh:masterfrom
wznmickey:hintDroppedCourses

Conversation

@wznmickey

Copy link
Copy Markdown
Contributor

Rebase #31 from 2.0.10 and take review into account.

@BoYanZh

BoYanZh commented Sep 15, 2022

Copy link
Copy Markdown
Owner

I think it will not raise an error as described in #26 now. Ignore the invalid course is enough.

@wznmickey

wznmickey commented Sep 15, 2022

Copy link
Copy Markdown
Contributor Author

I think it will not raise an error as described in #26 now. Ignore the invalid course is enough.

But each time the code running, there will be additional request to the server for each invalid course, which will increase the request rate that will make it more likely to be banned and waste server resources.

@BoYanZh

BoYanZh commented Sep 16, 2022

Copy link
Copy Markdown
Owner

Most requests come from listing files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants