Skip to content

Drop deprecated cibuildwheel options p36 p37#625

Merged
dlech merged 1 commit intoBluetooth-Devices:mainfrom
eshattow:cibw-drop-deprec-skip
May 7, 2026
Merged

Drop deprecated cibuildwheel options p36 p37#625
dlech merged 1 commit intoBluetooth-Devices:mainfrom
eshattow:cibw-drop-deprec-skip

Conversation

@eshattow
Copy link
Copy Markdown
Contributor

@eshattow eshattow commented May 2, 2026

Resolves: #618

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (58b364c) to head (cc42781).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   85.74%   85.68%   -0.06%     
==========================================
  Files          29       29              
  Lines        3487     3487              
  Branches      602      602              
==========================================
- Hits         2990     2988       -2     
- Misses        307      308       +1     
- Partials      190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 3, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing eshattow:cibw-drop-deprec-skip (cc42781) with main (58b364c)

Open in CodSpeed

@eshattow eshattow force-pushed the cibw-drop-deprec-skip branch from c9a892e to cf01756 Compare May 7, 2026 09:19
@eshattow eshattow deployed to release May 7, 2026 09:22 — with GitHub Actions Active
@dlech
Copy link
Copy Markdown
Member

dlech commented May 7, 2026

If you drop the first commit, then we could merge this.

@eshattow eshattow force-pushed the cibw-drop-deprec-skip branch from cf01756 to db06a84 Compare May 7, 2026 14:23
@eshattow
Copy link
Copy Markdown
Contributor Author

eshattow commented May 7, 2026

If you drop the first commit, then we could merge this.

Done, thanks for the hint.

Quiet warnings about deprecated no-op "*p36-*" and "*p37-*" options to cibuildwheel by removing the conditions
@eshattow eshattow force-pushed the cibw-drop-deprec-skip branch from db06a84 to cc42781 Compare May 7, 2026 14:27
@dlech dlech merged commit 06220c4 into Bluetooth-Devices:main May 7, 2026
22 of 24 checks passed
@eshattow eshattow deleted the cibw-drop-deprec-skip branch May 7, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github workflow Build wheels Warning: cibuildwheel: Invalid skip selector

2 participants