Skip to content

build: adjust actions checkout ref parameter on release#624

Open
eshattow wants to merge 1 commit intoBluetooth-Devices:mainfrom
eshattow:release-create-local-branch
Open

build: adjust actions checkout ref parameter on release#624
eshattow wants to merge 1 commit intoBluetooth-Devices:mainfrom
eshattow:release-create-local-branch

Conversation

@eshattow
Copy link
Copy Markdown
Contributor

@eshattow eshattow commented May 2, 2026

Let's use github.ref "ref:" parameter on release and create a local branch name.

Resolves: #622

@eshattow eshattow force-pushed the release-create-local-branch branch from a43d6c8 to d2c36d7 Compare May 2, 2026 23:38
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (58b364c) to head (89288cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   85.74%   85.68%   -0.06%     
==========================================
  Files          29       29              
  Lines        3487     3487              
  Branches      602      602              
==========================================
- Hits         2990     2988       -2     
- Misses        307      308       +1     
- Partials      190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 2, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing eshattow:release-create-local-branch (89288cc) with main (58b364c)

Open in CodSpeed

Let's use github.ref "ref:" parameter on release and create a local branch name.
@eshattow eshattow force-pushed the release-create-local-branch branch from d2c36d7 to 89288cc Compare May 7, 2026 09:09
@dlech
Copy link
Copy Markdown
Member

dlech commented May 7, 2026

Apparently this got moved to a new PR. My concern from #623 (comment) still applies here.

I would suggest either keeping the original logic and skipping this step for pull requests from forks or have two different branches, one for pull request and one for releases.

Any thoughts @bdraco?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow of dbus-fast not valid for accepting external Pull Request contributions

2 participants