Use authenticated npmrc#49557
Open
chidozieononiwu wants to merge 2 commits into
Open
Conversation
chidozieononiwu
requested review from
ArthurMa1978,
XiaofeiCao,
benbp,
haolingdong-msft,
raych1 and
weidongxu-microsoft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the eng/automation/generation.yml automation pipeline to use an authenticated .npmrc during npm operations, improving how npm credentials are handled in the generation workflow.
Changes:
- Adds a shared step to create/authenticate an
.npmrcin$(Agent.TempDirectory). - Configures npm install steps (autorest global install and
tsp-clientinstall) to use that.npmrcvianpm_config_userconfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
eng/automation/generation.ymlpipeline to improve authentication for npm operations by ensuring a properly configured.npmrcfile is used during package installation steps. The main focus is on securely handling npm credentials during the pipeline execution.Pipeline authentication improvements:
.npmrcfile using the/eng/common/pipelines/templates/steps/create-authenticated-npmrc.ymltemplate, specifying the path as$(Agent.TempDirectory)/release/.npmrc.autorestinstallation andtsp-clientinstallation) to use the authenticated.npmrcby setting thenpm_config_userconfigenvironment variable.